home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.13k stars 29.8k forks source link

HASS.IO v0.97.1 Lovelace Card not displaying correct KNX Operation Modes #26624

Closed G8YTZ closed 4 years ago

G8YTZ commented 5 years ago

In the States UI thermostats appear with the ability to select one of the 4 KNX Operation Modes. With 0.97 the Lovelace Card only displays 3 Operation modes and these do not work to change the Operation mode. The picture shows the Graphic that is incorrect, but the "drill-down" is ok.

Screenshot 2019-08-10 at 15 08 49
probot-home-assistant[bot] commented 5 years ago

Hey there @Julius2342, mind taking a look at this issue as its been labeled with a integration (knx) you are listed as a codeowner for? Thanks!

G8YTZ commented 5 years ago

0.97.2 has the same issue

elupus commented 5 years ago

This look like it's correct. HA only display modes in GUI. Presets are only in the drop-down.

So graphics will only show: off, auto, heat, cool.

G8YTZ commented 5 years ago

Until 95.4 it all worked properly, Colour changed and all buttons worked and am were present, definitely a bug in the latest release and 0.96

Sent from my Remington Rand UNIVAC www.g8ytz.com

On 13 Aug 2019, at 12:28, Joakim Plate notifications@github.com wrote:

 This look like it's correct. HA only display modes in GUI. Presets are only in the drop-down.

So graphics will only show: off, auto, heat, cool.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

elupus commented 5 years ago

Climate changed in 0.96: https://www.home-assistant.io/blog/2019/07/17/release-96/

G8YTZ commented 5 years ago

HI, this issue is far from closed. The issue relates specifically to the Lovelace Climate Card not displaying the 4 KNX operation modes from 0.96.x, it is not fixed in 0.97.x either. Look at my config above, it is to the book

To summarise: There are no issues using the STATES-UI, neither are there any issue using the LOVELACE UI using a simple thermostat, for example:

` - type: entities title: Lounge entities:

But using the Thermostat Card is where it all goes wrong. MY configuration in UI-LOVELACE.yaml is as follows:

` - type: vertical-stack # column 2 cards:

      - type: horizontal-stack
        cards:
          - type: thermostat
            entity: climate.master_suite_climate
            name: Master Bedroom`

So something has gone badly wrong with the Thermostat Card from 0.96

elupus commented 5 years ago

It is not that broken. There are not that many modes to display. "Comfort" is no longer a mode for climate. It's a profile. Lovelace card will only display valid modes, not profiles.

Yes it's reduction in function. Motivation is to keep modes in line with Alexa and Google Assistant.

G8YTZ commented 5 years ago

That just cannot be true, as I say it is only the Thermostat Card in Lovelace that is broken (the most important user interface) The fundamental STATES-UI work perfectly ok, so how can Lovelace be anything to do with Alexa?

OK so how should profiles be configured? The documentation is either incorrect or missing something really important. If it is intentional then I believe a re-think should be in order, grief even the documentation shows the Lovelace-UI example that worked for me a couple of weeks ago.

elupus commented 5 years ago

Can you link the documentation that you mention?

elupus commented 5 years ago

I don't fullt understand why you say graphics is wrong. It shows icons for selecting the mode. Ie off, auto, heat, cool.

There is no graphics for comfort, away, sleep, eco. Those you need to drill down into. Same goes for small also large Lovelace card, no difference there.

G8YTZ commented 5 years ago

Sure, the KNX Page shows the configuration.yaml entries, mine are identical (apart from the addresses of course) and worked perfectly. In the UI- Lovelace .yaml the configuration for a thermostat card, until 0.95.4 everything worked well - you saw the 4 modes and as you switched modes the ocular changed, so did the set point and as you switched modes this would be reflected in the graphics. Now there are only 3 modes shown and none of them work and the colours don't change.

KNX Climate: https://www.home-assistant.io/components/climate.knx/

Lovelace https://www.home-assistant.io/lovelace/thermostat/ - Note the 4 KNX modes!

KNX is the worldwide standard for building control - it's a professional solution for systems integrators:

The issue seems to be with the Thermostat Card as the STATES-UI is just fine. Many thanks for your help in anticipation.

Screenshot 2019-08-17 at 16 48 41
G8YTZ commented 5 years ago

I was going to say, we could do a WebEX if you would like to see the problem first hand.

selfisch commented 5 years ago

Hey, I dont exactly understand your initial Post

The picture shows the Graphic that is incorrect, but the "drill-down" is ok. But in your screenshot, everything seems fine.

For me nothing changed. Here an example of my configuration:

- platform: knx
  name: Wohnzimmer
  min_temp: 17.0
  max_temp: 23.0
  temperature_address: '1/1/11'
  target_temperature_state_address: '1/1/12'
  setpoint_shift_address: '1/1/13'
  operation_mode_address: '1/1/19'
Lovelace UI config:
  - type: entities
    title: Wohnzimmer
    show_header_toggle: false
    entities:
      - entity: climate.wohnzimmer

and a screenshot of the UI: image

and last but not least, a screenshot of knx debug log: image

So if I switch to one of the 4 modes, everything is fine. I am running HA0.97.2

G8YTZ commented 5 years ago

In the Lovelace UI Thermostat card only 3 modes are shown, but on the STATES UI all 4 are shown and this work properly. Also the mode buttons no longer work on the Lovelace UI and the state colours are not shown either.

The Lovelace UI Thermostat card has been useless since v 0.96, yet it worked perfectly on previous versions.

The key issue is with the Lovelace Thermostat Card. The picture here shows only three operation modes available when there should be 4 like there always was before.

Screenshot 2019-08-23 at 12 55 51
MartinHjelmare commented 5 years ago

I think you will get better visibility if we transfer this issue to the frontend repo, since it sounds like it's a frontend issue. Although it sounds like there has already been an answer to the change of behavior.

https://github.com/home-assistant/home-assistant/issues/25904#issuecomment-521810026

G8YTZ commented 5 years ago

I did see that comment about reduction in functionality, but that cannot be true, frankly if this does not work I'm wasting my time going with Home Assistant.

KNX is the worldwide BMS standard with massive adoption, Google and the like are just toys.

balloob commented 5 years ago

No functionality was reduced, it's just accessible as a preset instead of an hvac mode.

G8YTZ commented 5 years ago

The whole Lovelace Thermostat interface is now basically useless, but the documentation does not say this. How is the current operation mode displayed? How is it usable from a finger on an iPhone or on a car dashboard or a touchscreen phone like the Gigaset Maxwell 10? This was what was so brilliant - easy to use and not it does not work with the leading BMS system. That cannot be right.

selfisch commented 5 years ago

In the Lovelace UI Thermostat card only 3 modes are shown, but on the STATES UI all 4 are shown and this work properly. Also the mode buttons no longer work on the Lovelace UI and the state colours are not shown either.

The Lovelace UI Thermostat card has been useless since v 0.96, yet it worked perfectly on previous versions.

The key issue is with the Lovelace Thermostat Card. The picture here shows only three operation modes available when there should be 4 like there always was before.

Screenshot 2019-08-23 at 12 55 51

Now I got the point, sorry for that! You are absolutely right. I am currently not using that kind of card in lovelace ui, but hopefully those modes wont be taken away completely from the knx climate integration :-)

G8YTZ commented 5 years ago

Cool! here is what the thermostat page looks like (prior to 0.96) on my Tesla Screen/ Nabu Casa, you can see the thermostats have all modes and can easily be operated by a finger. My plan is to buy the Gigaset Maxwell 10S VOIP phone for my Asterisk system and use the Android OS on the phone to install the HA App and use it to control functions for that room, situated next to the sofa on the coffee table. I think that would be great use for HA as a room controller.

IMG_2041

G8YTZ commented 5 years ago

A video also....

https://youtu.be/10nqj6f0uwc

Mariusthvdb commented 5 years ago

wow, looking mightily impressive. But please don't tell us you have 12 thermostats ..? (sorry if this diverges from the OP)

G8YTZ commented 5 years ago

The house is KNX, only diverges for things like Yale Conexis integration (via Smartthings Hub) external web sensors, HIK Vision Cameras, Cars etc. I took a KNX certification course 10 years ago when planning the house self-build.

The heating consists of a Mitsubishi Ecodan air-water Heat Pump, Theben HMT12 actuator that controls 11 underfloor zones and then there are 4 electric towels radiators in the bathrooms, so there are actually 15 zones, though several are dual heat zones.

The thing I like about KNX is that it's and open protocol and a "walled garden" - one configuration tool for all manufacturers and 100% compatibility between manufacturers is gauranteed. The design life of the kit is about 25 years, no software updates required. It just works and does not become obsolete.

Next integration challenge is the Resol solar thermal controller, might do the PV too, but right now I use a Zennio KEX KNX current sensor to measure power.

G8YTZ commented 5 years ago

Hi, is anyone looking at this issue since 0.96? It has completely broken the KNX thermostat integration. Someone has not thought these changes through, a major backward step that writes off HASS for use with KNX which is the largest professional BMS out there.

iantrich commented 5 years ago

The card shows modes, not presets. You can access the more-info dialog which shows the presets by clicking the top right icon. I don't consider this issue based on your description. The modes of the integration changed, not our display.

G8YTZ commented 5 years ago

Yes the Operation Modes don't work anymore. It has completely destroyed the UI with Lovelace how can the card show and control the operation modes correctly again? There must be a fix. Whatever had been done has ruined the interface. Check out how the colours used to change with mode too, not any more.

iantrich commented 5 years ago

I see. People seemed to be focusing on the number of modes rather than the failure of the buttons and is what I picked up on as well.

So to be clear, all the mode buttons on the card no longer work for you but selecting from the drop-down does work?

G8YTZ commented 5 years ago

Yes, that's correct, also you see only 3 operation mode buttons and before there were 4. The picture on the Tesla Dash vs the other (post 0.96) pictures I took. The Lovelace card lends itself very well to a touchscreen, the drop-down does not.

iantrich commented 5 years ago

Let's not conflate the two issues. I think the buttons working is of importance. The modes was a bacoend choice which can be discussed in another issue.

G8YTZ commented 5 years ago

Nothing wrong with the back-end controls at all - the dropdown works as it always did. The issue as you say is that the Lovelace card no longer works correctly and does not display the correct operation modes. In my first picture I showed the dropdown was ok with all the modes.

iantrich commented 5 years ago

That drop-down is not modes, it's presets. You're conflating the two issues again. Presets will not be in the card.

G8YTZ commented 5 years ago

They are defined a "Operation Modes" in KNX. It worked properly before 0.96. Also how do you explain that the Card thermostat trace colours no longer change in the Lovelace Card? They are all grey.

iantrich commented 5 years ago

I'm not going to debate operation modes with you, that was a decision by the core backend devs to better align integrations. They are effectively presets/actions in terms of what the frontend sees.

As for "traces", I don't know what that means and is again a different tangent.

iantrich commented 5 years ago

@pvizeli is what I'm saying accurate for climate 1.0?

G8YTZ commented 5 years ago
Screenshot 2019-09-11 at 23 29 16

OK, look at the Tesla dashboard picture, you see green and orange thermostat traces according to KNX operation modes (call them presets if you like, but the correct KNX term is operation mode) Also look at why not all of the "presets" are displayed anymore there should be 4. Whatever the backend devs have decided they have broken a very important integration and broken Lovelace too, so the best thing is to revert or add a switch in the software, but I think this is a serious oversight or at best a bug.

G8YTZ commented 5 years ago
Screenshot 2019-09-11 at 23 33 35

Now always grey and only 3 "presets" The 4 operation modes or presets should be: Frost Protect Comfort Away Sleep/Night

pvizeli commented 5 years ago

I think the issue is: Before 0.96 - Our Climate Object was based on the integration (in your case KNX) Now - We have our own Climate Handling / The integration map this to interface

That means, whatever your KNX say, that does not mean it is mapped like this into Home Assistant.

That it shows wrong on UI is, because the KNX team on HA did not integrate our model correct. I move this issue back to Home Assistant and ping the KNX team. I can not promise that they are active and fix that soon.

Referenz: https://developers.home-assistant.io/blog/2019/07/03/climate-cleanup.html

pvizeli commented 5 years ago

@Julius2342 I think the issue is that on preset, it does not map an hvac mode.

G8YTZ commented 5 years ago

Hi! Many thanks! I think you have hit the nail on the head, if this can be fixed. Actually I am a KNX professional, but my real job is in telecoms. I did the KNX certification for my self-build house. I've been using a commercial remote control system, but it is proving too restrictive in integrating IoT and other things, like cars, locks, media, weather, Velux, plant monitors, and lots of the things. When I found Home Assistant (I also looked at Open HAB and others) I saw it was just ideal and probably the best solution out there.

For me removing this important feature/capability for KNX has undermined its usefulness, so I do hope this issue is addressed. The other thing is we do need to get to a LTS version where it can run for years without having to touch it and there is a straightforward way of upgrading to the latest LTS version. Here I'm thinking like Asterisk is where we should get to.

I am looking at using Asterisk (I already have it and SNOM phones) with a Gigaset (or similar) Maxwell 10s Android phone and having the 10" touchscreen be the room controller via a Home Assistant page, so you have a dedicated room plan with controls on the phone in each room. That's why touch screen thermostats are so important to this idea, the Lovelace Thermostat card is perfect - as it previously worked.

Best regards - Justin

elupus commented 5 years ago

Well. I think backend is correct according to HA behavior.

OPERATION_MODES = {
    # Map DPT 201.105 HVAC control modes
    "Auto": HVAC_MODE_AUTO,
    "Heat": HVAC_MODE_HEAT,
    "Cool": HVAC_MODE_COOL,
    "Off": HVAC_MODE_OFF,
    "Fan only": HVAC_MODE_FAN_ONLY,
    "Dry": HVAC_MODE_DRY,
}
PRESET_MODES = {
    # Map DPT 201.100 HVAC operating modes to HA presets
    "Frost Protection": PRESET_ECO,
    "Night": PRESET_SLEEP,
    "Standby": PRESET_AWAY,
    "Comfort": PRESET_COMFORT,
}

The problem is that @G8YTZ consider the Lovelace gui completely broken if it isn't able to control presets directly. As you can see above on presets those would never map to HA HVAC modes.

So I still see this as a GUI issue, or no issue at all.

elupus commented 5 years ago

I tend to the GUI fault, since the likely thing you want to do is change the profile of your HVAC, not turn it completely on/off.

G8YTZ commented 5 years ago

Yes,

I agree it’s a GUI issue, but it’s an issue because the back end changed and the GUI did not.

Justin.

Sent from my Remington Rand UNIVAC www.g8ytz.com

On 13 Sep 2019, at 14:03, Joakim Plate notifications@github.com wrote:

 Well. I think backend is correct according to HA behavior.

OPERATION_MODES = {

Map DPT 201.105 HVAC control modes

"Auto": HVAC_MODE_AUTO,
"Heat": HVAC_MODE_HEAT,
"Cool": HVAC_MODE_COOL,
"Off": HVAC_MODE_OFF,
"Fan only": HVAC_MODE_FAN_ONLY,
"Dry": HVAC_MODE_DRY,

} PRESET_MODES = {

Map DPT 201.100 HVAC operating modes to HA presets

"Frost Protection": PRESET_ECO,
"Night": PRESET_SLEEP,
"Standby": PRESET_AWAY,
"Comfort": PRESET_COMFORT,

} The problem is that @G8YTZ consider the Lovelace gui completely broken if it isn't able to control presets directly. As you can see above on presets those would never map to HA HVAC modes.

So I still see this as a GUI issue, or no issue at all.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

probot-home-assistant[bot] commented 5 years ago

Hey there @Julius2342, mind taking a look at this issue as its been labeled with a integration (knx) you are listed as a codeowner for? Thanks!

pvizeli commented 5 years ago

@elupus you need also map an hvac state if a preset is active

elupus commented 5 years ago

@pvizeli, even if that was a bug in backend, it won't help here.

Eco and FrostProtection profiles will both be mapped to heat_cool HVAC mode.

There will be no way from Lovelace card to directly switch between eco and frostprotection, they map to same HVAC mode. There is no profile selection. And both would be under the single button for heat_cool.

G8YTZ commented 5 years ago

The lack of a frost protect mode I could live with, though not ideal. Frankly when something was not broken why fiddle with it? I think the best way forward is to back out this change that was made in 0.96 and have a re-think on the strategy. There was noting wrong with thermostats before this.

moustic999 commented 4 years ago

wow, looking mightily impressive. But please don't tell us you have 12 thermostats ..? (sorry if this diverges from the OP)

I have my home fully equipped in KNX and I have 22 thermostat. 1 per room. Each one manage temperature for it's own room. plus 1 which manage heater.

G8YTZ commented 4 years ago

I’d dearly love this issue fixed... Just back out the failed change.

moustic999 commented 4 years ago

Most of the people having KNX thermostat @home rely on operation mode of KNX. Only very few people , and moslty Commercial building use the HVAC mode of KNX. The issue is that with the new climate and Lovelace UI, only HVAC modes are in use ( operation mode become presets and need multiple action to be usable). @G8YTZ I have the same issue here at home, and I really hope a solution will be found. Maybe posting a entry in the architecture issues could help, at least to have a discussion on this.

stale[bot] commented 4 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.