search

honojs / create-hono

CLI for creating a Hono app
41 stars 12 forks source link

Got rate limit error #15

Closed arronKler closed 3 months ago

arronKler commented 7 months ago

Got rate limit error from viaContentsApi call when execute npm create hono

image

yusukebe commented 7 months ago

Hi @arronKler

This is a limitation of the GitHub API, which create-hono uses. I would like to address this issue, but it's challenging to remove the dependency on GitHub now.

However, there may be some ideas to resolve this. Let's keep this issue open for now. Thank you.

ryuapp commented 5 months ago

I think it would be better to include starter templates in this package. For example, create-vite.

That will resolve this issue and we can get old Hono templates. The latter has no pros, it's just a historical legacy.

yusukebe commented 5 months ago

@ryuapp

Yeah, but we need to update the template with library version upgrades and minor fixes. So I would prefer not to include it in create-hono as much as possible, but is there a better way?

JunQu commented 3 months ago

i have the same problem

anhtuank7c commented 3 months ago

Unbelievable they keep this issue open that long.

yusukebe commented 3 months ago

@anhtuank7c

We have our own priorities.

yusukebe commented 3 months ago

@ryuapp

For this Issues, I don't want to include the template in create-hono as much as possible, can't we have it downloaded from GitHub without using the GitHub API?

anhtuank7c commented 3 months ago

I think this is a gate for everyone to jump into Hono world but it just doesn't work. Its like you're selling thing that people want to buy it then you said: sorry, we don't have it. @yusukebe sure, keep your own priorities. I will find alternative such as Elysia.

yusukebe commented 3 months ago

@anhtuank7c

I see what you mean, but this error only occurs in environments that are rate-limited by GitHub's API. So not everyone will face this problem.

anhtuank7c commented 3 months ago

@yusukebe if you think it's a bug, it will be fixed one day. If you think it's not a bug, it will never be fixed because you never give a try at least once.

yusukebe commented 3 months ago

I solved this problem in a simple way that now it does not use GitHub API, so this error may not thrown with the latest version!

@ryuapp

After all, I've hard coded the list of templates.

anhtuank7c commented 3 months ago

🎉🎉🎉 @yusukebe Wow, what a beautiful fix.