search

honojs / create-hono

CLI for creating a Hono app
41 stars 12 forks source link

feat: add `name` as projectName to cloned project template package.json #48

Closed BRAVO68WEB closed 3 weeks ago

BRAVO68WEB commented 3 weeks ago
BRAVO68WEB commented 3 weeks ago

Added requested changes

yusukebe commented 3 weeks ago

@BRAVO68WEB

Thank you for updating it. But still, I got the error when choosing the deno:

CleanShot 2024-06-13 at 11 21 11@2x

Can you see it?

BRAVO68WEB commented 3 weeks ago

Got it, my bad I used a different logic for checking for package json.

On Thu, 13 Jun, 2024, 7:54 am Yusuke Wada, @.***> wrote:

@BRAVO68WEB https://github.com/BRAVO68WEB

Thank you for updating it. But still, I got the error when choosing the deno:

@.*** (view on web) https://github.com/honojs/create-hono/assets/10682/40c308e2-f766-42e2-a760-1a89f9b70ec3

Can you see it?

— Reply to this email directly, view it on GitHub https://github.com/honojs/create-hono/pull/48#issuecomment-2164231265, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ4HJV4U3YW33EK4F6JYYJLZHD7HBAVCNFSM6AAAAABJBGPAH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRUGIZTCMRWGU . You are receiving this because you were mentioned.Message ID: @.***>

yusukebe commented 3 weeks ago

@BRAVO68WEB

Great! Let's go with it. Thank you for the nice feature!