Improve bundle size - Githubissues

honojs / create-hono

CLI for creating a Hono app

50 stars 14 forks source link

Improve bundle size #66

Open goisaki opened 3 weeks ago

goisaki commented 3 weeks ago

The binary size of create-hono is currently 1.39 MB. This is clearly larger than ~create-remix (93.3kB)~(with dependencies) and create-vite (56.9kB) and should be improved.

These are some of the ways to improve:

[ ] Stop using commander.
- arg-parser can be replaced by node:util's parseArgs.
- usage can be replaced by console.log.
[ ] Use @clack/core instead of @inquirer/* and nanospinner (225kB total)
[ ] Self-implement giget(342kB)
- giget has more features than needed and is heavy
- create-remix did it.

I have already tried all of this locally and can make a PR right away. I would like to hear @yusukebe, @ryuapp, and @MathurAditya724's opinions on these changes.

yusukebe commented 3 weeks ago

Hi @goisaki

Here are my thoughts:

We don't have to minify it. It should be easy to debug.
We should compare "install size"s. You can see them at https://pkg-size.dev/
This package will be cached when the user runs the create hono command many times. I think we don't need to be strict about file size.

goisaki commented 3 weeks ago

Hi @yusukebe What do you think about @clack/prompts? It has a very cool UI, small size and also a graceful message on exit.

yusukebe commented 3 weeks ago

@goisaki

Looks good. But can you create the UI similar to the current version with @clack/core not using @clack/prompts?

goisaki commented 3 weeks ago

hi @yusukebe

Understood. As such, I will make a PR.

It would be more effective to migrate the chalk of the duplicate feature package to picocolors (which @clack/core depends on, smaller in size), is that ok?
I would also like to hear why we need to keep a similar UI and only use @clack/core. If “UI” means “behavior” (excluding appearance), then we can make it look better without changing the content or order of the prompts.

I am positive about changes/improvements to the look and feel because it makes the experience better.

yusukebe commented 2 weeks ago

@goisaki

It would be more effective to migrate the chalk of the duplicate feature package to picocolors (which @clack/core depends on, smaller in size), is that ok?

Yes.

I would also like to hear why we need to keep a similar UI and only use @clack/core.

Because I like the way it looks now. Also because I worry that using @clack/prompts will make it look like any other create-* that uses it.