search

howardchung / watchparty

Watch anything together in-sync with your friends
https://www.watchparty.me
MIT License
691 stars 130 forks source link

Mp4 with audio in 5.1 format not working on recieving end #592

Closed UnderKoen closed 1 year ago

UnderKoen commented 1 year ago

When using a video which uses 5.1 audio, the other user in the party don't hear all channels (mostly not voices). When using FFMPEG to convert the audio to stereo it does work.

It would be nice if this process would not be needed.

howardchung commented 1 year ago

Unfortunately I think this is a browser limitation--but possibly could be fixed in the future with the correct WebRTC settings + browser support.

(you can test this by trying to play the video using your browser directly--if you also don't hear the audio there it won't be shareable via WatchParty)

UnderKoen commented 1 year ago

The file does work in the browser and on watchparty for the person who shares the file. But only on receiving browser it does not work.

howardchung commented 1 year ago

Interesting--in that case there may be some WebRTC tweak to make it possible to share all the channels

This post seems to explain the hidden multiopus option: http://webrtcbydralex.com/index.php/2020/04/08/surround-sound-5-1-and-7-1-in-libwebrtc-and-chrome/

howardchung commented 1 year ago

mistagged in the commit but it's this one: https://github.com/howardchung/watchparty/commit/d6d62050b14d9afdaf3ccd48ffcf7b602a75d2cd