search

howardchung / watchparty

Watch anything together in-sync with your friends
https://www.watchparty.me
MIT License
743 stars 137 forks source link

Disable notification sounds when the video is paused/played #849

Closed cyber-sec0 closed 8 months ago

cyber-sec0 commented 10 months ago

There is no need to play a notification sound when the video is paused/played, because this is an action that is very easy to notice no matter what, videos usually have sound, which would call everyone's attention, so having a notification sound playing in both cases seems needless to me, or if we could at least disable "video interaction" sounds that would be nice.

howardchung commented 8 months ago

I think more generally this is just a case of the notification sound triggering because a new system event has been written to the log. We could probably just disable the sound unless it's a user chat message.