search

hoxfon / react-native-twilio-programmable-voice

React Native wrapper for Twilio Programmable Voice SDK
MIT License
180 stars 153 forks source link

fix deviceReady event never fires issue #186

Closed gongdao123 closed 3 years ago

gongdao123 commented 3 years ago

If the cachedDeviceToken is founded, the deviceReady event will never fire before. This PR address that issue, also mentioned here #155

jdegger commented 3 years ago

Hello thank you for your PR @gongdao123! Highly appreciated.

We will review as soon as possible. The code seem straight forward, so if @fabriziomoscon agrees we can merge this.

jdegger commented 3 years ago

Hi @gongdao123 could you please elaborate on your new commit? Thanks!

danstepanov commented 3 years ago

@jdegger It looks like @gongdao123 is simply accounting for the situation in which an empty action (no string) is passed in. Correct me if I'm wrong. This is a much needed merge as these events are not firing properly.

danstepanov commented 3 years ago

For what it's worth, i have tested this change and it doesn't seem to fix the issue.

jdegger commented 3 years ago

@danstepanov thank you for testing. So far @fabriziomoscon has let me know that currently the PR does not fully make sense yet. When he has time he will of course comment here.

fabriziomoscon commented 3 years ago

@danstepanov @jdegger I have pushed a fix to master, please let me know if it works

fabriziomoscon commented 3 years ago

react-native-twilio-programmable-voice@4.3.1