hoxfon / react-native-twilio-programmable-voice

React Native wrapper for Twilio Programmable Voice SDK
MIT License
181 stars 152 forks source link

Sends deviceReady event when using Cached token #199

Open fmonsalvo opened 3 years ago

fmonsalvo commented 3 years ago

Some applications may rely on the deviceReady event to be thrown to understand the VOIP functionality is ready. When using the cached token the lib was not sending the deviceReady event. This PR fixes that.

jdegger commented 3 years ago

Hi @fmonsalvo thanks for your PR. It seems like there is a merge conflict, could you resolve this?

fabriziomoscon commented 3 years ago

I think that there is already an open PR to fix this.

fmonsalvo commented 3 years ago

Hey guys, sorry for my late reply. If there is already an open PR for this I should close it. Else I'll fix the merge issue and update it. Let me know what should I do.