search

hoxfon / react-native-twilio-programmable-voice

React Native wrapper for Twilio Programmable Voice SDK
MIT License
181 stars 152 forks source link

Twilio android sdk 5 bugfixes #205

Closed ro-mgh closed 3 years ago

ro-mgh commented 3 years ago

Guys, thank you for your work!

This PR fixes and adds the following functional:

  1. Added unregistration for android
  2. Fixed unregistration for IOS
  3. Solved issue: " Call invite heads-up notification are not auto cancelled. This issue happens when a call is received and the screen is locked or the screen in unlocked, but the app is in the background. The heads-up notification service is started. If the user taps on the notification full screen content (not reject nor answer button), and then accepts the call from JS, at the end of the call the heads-up notification won't be removed, because there is no push notification for end call, just for call invite cancelled by the caller. I don't know how to solve this issue, because endForeground() can only be called by the service and all the user interactions from JS end are handled by the VoiceModule. At the same time full screen content is needed to show the JS incoming call screen when the phone is locked, therefore it can't be removed. "
  4. Solved a bug with infinite ringing.

Please feel free to contact me in case of questions)

ro-mgh commented 3 years ago

@fabriziomoscon

fabriziomoscon commented 3 years ago

thank you for the fixes. When you have done with the latest fix I will squash all the commits, so if you want to keep more than one commit for isolation of feature (your choice), please reorganise the final commits as you want and force push.

ro-mgh commented 3 years ago

@fabriziomoscon , Feel free to squash all my commits, and thank you for your response!

fabriziomoscon commented 3 years ago

thank you