search

hoxfon / react-native-twilio-programmable-voice

React Native wrapper for Twilio Programmable Voice SDK
MIT License
180 stars 153 forks source link

The app keeps active and forces the device to keep alive after reject/disconnect #68

Open armanrma7 opened 6 years ago

armanrma7 commented 6 years ago

version of React Native: 0.52.0 version of react-native-twilio-programmable-voice: ^3.0.0 device: iOS8.1 device/ Android 5+ device iOS pod version: 1.4.0

Step to reproduce: Android scenario:

  1. I'm getting an incoming
  2. Rejecting the call Result: The call has been successfully rejected. BUT the app keeps active and forces the device to keep alive, I have to manually kill the app in order to back the device to it's normal state.

IOS scenario

  1. I'm doing outbound call
  2. I'm disconnecting that call Result: Exactly the same as on Android

Did you try to reinstall the pods completely: Yes, it was not helped

fabriziomoscon commented 6 years ago

@armanrma7 Thanks for creating this issue. First of all you can't use Apple CallKit with iOS < 10.0 https://developer.apple.com/documentation/callkit

Second I will suggest to update to the latest lib version v3.12.0 and update your Podfile with pod 'TwilioVoice', '=2.0.0-beta21'

Android scenario What do you expect to happen? What is the normal state of the device? On Android you can accept or reject the call directly from the notification. If you reject the call from the notification and the app is not in memory the app should not be initialised.

iOS scenario If you are disconnecting the call from the app screen, the app should receive the event connectionDidDisconnect and you can change the UI accordingly in your react-native code. If you are disconnecting the call from within the iOS (I am not sure how you are doing it) I am not sure what will happen to the app.

armanrma7 commented 6 years ago

Thanks for the response.

I'll update what you've mentioned.

Android scenario The thing is that after rejecting the call, even the device's home button doesn't react. Also when I'm locking device by power button, then unlocking it -> the device behaves like it was not locked

Note: above mentioned scenarios are reproducible in both cases

Thanks, Arman

jdegger commented 3 years ago

This issue will be resolved by implementing the ConnectionService on Android as outlined in #158.