hoyois / clicktoplugin

Prevents plug-ins from loading automatically in Safari
http://hoyois.github.com/safariextensions/clicktoplugin/
228 stars 44 forks source link

Not Working #185

Open desepticon opened 6 years ago

desepticon commented 6 years ago

All of a sudden it stopped working for me a few minutes ago. Adding the additional killers located in another topic did not fix it, replacing them with just those killers didn't fix it, enabling/disabling didn't fix it, nor did quitting Safari and reopening..

koke6645 commented 6 years ago

YouTube killer broken again

rorya commented 6 years ago

ditto.

ElmerCat commented 6 years ago

Yes, me too — I love Click-to-Plugin and have used it, and Click-to-Flash before it for years. It's happened before, where it'll suddenly stop working on YouTube, but then start working again at a later time. Maybe that will happen here too.

Whatever happens, I'm grateful to Marc, Jonathan, and everyone else who's worked on this over the years!

a-greyyyyy commented 6 years ago

ditto. got home a hour ago, it's not working anymore... hoping this is just the usual temporary glitch.

poweruser82 commented 6 years ago

See https://github.com/hoyois/clicktoplugin/issues/180#issuecomment-298171894

vmachiel commented 6 years ago

Maybe take the discussion to the killer github page to draw attention? Hopefully someone knows a fix. I've opened an issue: https://github.com/hoyois/plugin-to-html5/issues/30

RandomDSdevel commented 6 years ago

Just encountered this issue myself a little bit ago, and I agree this is kind of annoying. (Not that it might not help that I don't use ClickToFlash for its originally intended purpose, but I don't think that's the problem, as my configuration worked just fine before today.)

rorya commented 6 years ago

Interestingly, youtube-dl v2017.06.05 still works, despite whatever YT has changed within the last day or two on the video page, which has broken CTF. I wonder if there is a difference in youtube-dl's design which makes it more resilient to site changes. AFAIK, it also resorts to having to extract video info from the video page, much as CTF does.

vmachiel commented 6 years ago

It must be a problem with the CSS selector to get the video to kill. It happened before and @hoyois was so nice to write a CSS fix script. (https://raw.githubusercontent.com/hoyois/plugin-to-html5/master/CSSfix.js)

Maybe he or someone else that knows JS and CSS can help?

ElmerCat commented 6 years ago

Thank you, @rorya for the reference to rg3/youtube-dl — it took a little figuring out, but works nicely!

elee1989 commented 6 years ago

The extension continues to work normally with embedded Youtube videos. So I'm using the Javascript bookmarklet provided by nsfwyoutube.com to load Youtube videos within their website as embedded videos and it works fine.

rorya commented 6 years ago

Yeah, even though I use an older version of Saf, which didn't need this CSSfix.js to work, it does seem to be behaving how Saf 10 did, before CSSfix.js was introduced. So you may be right, vmachiel, this may be a styling-related show stopper as well. It would also explain why youtube-dl is unaffected since it does not need to make any UI alterations, just needs to extract the appropriate video URL from the video page. So it has a simpler goal.

Fofer commented 6 years ago

Same here. YouTube pages aren't loading ClickToFlash, but embedded YouTube videos elsewhere work fine. Hopefully an update to the YouTube killer will be able to address this... :(

a-greyyyyy commented 6 years ago

embedded videos aren't working for me

RandomDSdevel commented 6 years ago

@vmachiel:

It must be a problem with the CSS selector to get the video to kill. It happened before and @hoyois was so nice to write a CSS fix script. (https://raw.githubusercontent.com/hoyois/plugin-to-html5/master/CSSfix.js)

Maybe he or someone else that knows JS and CSS can help?

Sadly, it'll probably have to be somebody else, as @hoyois's user page doesn't show him as being very active as of late… (Oh, wait; even if somebody else did help, @hoyois would have to merge the resulting PR in. Scrap. Anybody know how to contact the guy?)

Haravikk commented 6 years ago

Since the code is on Github I think someone could just fork their own click to plugin project and let people it build it from there, unless there's a license that prevents it.

I noticed the same issues with YouTube, only way to fix it was to disable click to plugin entirely.

I know nothing about building Safari extensions, but if someone hasn't beaten me to issuing a fix I might give it a try if I can find the time.

RandomDSdevel commented 6 years ago

@Haravikk: The only problem with that idea is that you'd have to make sure everybody abandoned the project's current home page and update feed by having them uninstall @hoyois's original version of ClickToFlash and install your fork. (And, come to think of it, end users would have to figure out how to copy all of their settings over intact if those can't be dumped and restored — probably just by taking pictures of them and/or listing them in a text file and working from those/that.)

P. S.: With regard to what initially caused this issue to be reported, the obvious fix for it doesn't satisfy me when tried under my personal configuration. It works, but then videos like to stutter…

ElmerCat commented 6 years ago

@a-greyyyyy Some embedded videos work, but others don't. Recently, when things were working, some YT videos would download directly, while others would open in a player first, but that could be downloaded. It seems the ones that opened in the player are the ones that don't work embedded.

Luckily, rg3/youtube-dl works for any video. It's really quite amazing, all that it does! I really hope the convenience of Click-to-Plugin comes back again; meanwhile using the command line isn't that much trouble, if your objective is to watch videos offline.

a-greyyyyy commented 6 years ago

@ElmerCat

i tried youtube-dl, but i couldn't get it to install via terminal. or do you have to use the command line every time you want to dl a video? i can't quite suss it out.

since i use firefox as a secondary browser, i've resorted to using video downloadhelper whenever i want to rip a video. a bit of a annoyance, but it'll do until this either fixes itself, or someone comes up with a fix.

mrkapqa commented 6 years ago

if you use firefox, one can still resort to greasemonkey + viewtube by sebaro for downloading video (functions even better on linux, though); would be great to see rise clicktoplugin from the ashes ; on 10.4 - 10.6 one could use also ppc media center, but on newer OS(X) this program won't function anymore.

mrkapqa commented 6 years ago

another terminal based option for accessing youtube elegantly is youtube-viewer (perl); in adjunction mpv player is needed or a newer version of mplayer (via homebrew or macports); but to be honest, my favorite is and was clicktoplugin + quicktime 7 player + afloat bundle ! lets hope the best that it will come back!

vmachiel commented 6 years ago

Maybe we should move the discussion to the github page for the killer scripts? Last time there was an issue, a solution was found there: https://github.com/hoyois/plugin-to-html5/issues/30

mrkapqa commented 6 years ago

thought that on all my macs clicktoplugin is broken, but it on my macpro running snow leopard is still active; at least i could watch sandboxed videos via quicktime plugin on RT International; only tweak needed is this killer here https://raw.githubusercontent.com/hoyois/plugin-to-html5/master/YouTubeXHR.js

RandomDSdevel commented 6 years ago

And thus the plot thickens… 🤔

elee1989 commented 6 years ago

My initial comments about a workaround with nsfwyoutube.com are no longer valid. The plugin is currently broke for me. Does the updated CSSfix.js still work?

RandomDSdevel commented 6 years ago

@elee1989 to reiterate this issue thread's current status despite being forced to repeat some of its contents and context to do so: No, the update to CSSfix.js from last time this happened does not, as evidenced by this issue, seem to suffice in resolving it. @hoyois will either need to resolve hoyois/plugin-to-html5#30 himself or merge a PR into that repository that does, then release a rebased version of ClickToFlash that includes the updated killer script internals. Unfortunately, @hoyois still doesn't seem to be around, and nobody has stepped up with a PR, either, though @hoyois's absence would still prevent that from getting merged. (I'd help, but I don't really know JavaScript and/or CSS at all.)

mrkapqa commented 6 years ago

can confirm that the sandboxed videos do work only on a MacPro where ClickToPLugin has been previously used with success; on a fresh installation i was not able to use ClicktoPlugin (neither Snow Leopard, nor Leopard, nor Mavericks) with QUicktimePlugin as desired, not matter which options used. Quicktime would then only work when selected in Developer Options "UserAgent > IOS xx"

Am 05.08.17 um 21:02 schrieb Bryce Glover:

@elee1989 https://github.com/elee1989 to reiterate this issue thread's current status despite being forced to repeat some of its contents and context to do so: No, the update to |CSSfix.js| from last time this happened does not, as evidenced by this issue, seem to suffice in resolving it. @hoyois https://github.com/hoyois will either need to resolve hoyois/plugin-to-html5#30 https://github.com/hoyois/plugin-to-html5/issues/30 himself or merge a PR into that repository that does, then release a rebased version of ClickToFlash that includes the updated killer script internals. Unfortunately, @hoyois https://github.com/hoyois still doesn't seem to be around, and nobody has stepped up with a PR, either, though @hoyois https://github.com/hoyois's absence would still prevent that from getting merged. (/I'd/ help, but /I/ don't really know JavaScript and/or CSS at /all/.)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/hoyois/clicktoplugin/issues/185#issuecomment-320464026, or mute the thread https://github.com/notifications/unsubscribe-auth/AMWQCbpNKivhd8t5S2geDWKYRVKi_QWeks5sVLxhgaJpZM4Okt8A.

RandomDSdevel commented 6 years ago

Huh, in-teresting… Have you tried the same procedure on any OS X/macOS release higher than Mavericks? (Given other reports, such a test would probably fail, but it's always good to double-check something, right?)

mrkapqa commented 6 years ago

Well...i have another partitiin with ElCalitano where it never workedcas desired because Plugin 7.7.1 is not recognuzed only 7.7.3 and therefore it was not possible to float the qicktime anymore. On Sierra there seems to be an inbuilt Floating mechanism as you can detach the window and play in a corner but this functions on html5 basis i guess and playback stops when you search for another video or close the youtubepage. On yosemite it was still fully functional but i guess now it is no more activable unless hoyois blezz us with some changes Am 05.08.2017 10:29 nachm. schrieb Bryce Glover notifications@github.com:Huh, in-teresting… Have you tried the same procedure on any OS X/macOS release higher than Mavericks?

—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or mute the thread.

RandomDSdevel commented 6 years ago

@mrkapqa: Yeah, I'm stuck on El Capitan due to my machine not meeting macOS Sierra's system requirements and have experienced much the same loss of functionality. I don't have ClickToFlash pipe YouTube videos through to Quicktime, but I do have it block the HTML5 player in favor of the Flash player (the former stutters too much for my taste on my machine, as its buffering behavior differs from that of the latter.) And Picture-in-Picture Mode (the official term for the 'floating' you've described) was only introduced in Sierra, so you'd only see it there.

a-greyyyyy commented 6 years ago

@RandomDSdevel ditto here... i'm stuck on el capitan, myself, because my machine is too "old" (late 2008 13" unibody macbook 5,1).

RandomDSdevel commented 6 years ago

@a-greyyyyy: Yeah, I'm using my family's mid-2007 iMac (iMac7,1,) but booted from an external drive, as my setup at the moment, not that it's really all that germane to this discussion, but anyhow… — well, back to the topic at hand, right?

hoyois commented 6 years ago

The problem is that the YouTube killer is not able to force Flash on YouTube anymore. Sadly, I have no idea how to fix this, especially since the same hack still works on embedded videos.

mrkapqa commented 6 years ago

There is a guy called Adam Albrec who created PPC Mediaa Center for PPC. By copying the link from Youtube onto the Program, it still open the video in Quicktime 7 and plays it back ... Maybe we could ask him to share the code for a joint effort?

Von meinem iPad gesendet

Am 06.08.2017 um 21:22 schrieb Marc Hoyois notifications@github.com:

The problem is that the YouTube killer is not able to force Flash on YouTube anymore. Sadly, I have no idea how to fix this, especially since the same hack still works on embedded videos.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

mrkapqa commented 6 years ago

Also the Quicktime Enabler on TFF (tenfourfox) is still working with Youtube on Powerpc , so there must be a way.

Von meinem iPad gesendet

Am 06.08.2017 um 21:22 schrieb Marc Hoyois notifications@github.com:

The problem is that the YouTube killer is not able to force Flash on YouTube anymore. Sadly, I have no idea how to fix this, especially since the same hack still works on embedded videos.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

mrkapqa commented 6 years ago

if any of you guys are on Powerpc Macs and don't know PPC MediaCenter you should check it out First install Version 6 from here http://ppcluddite.blogspot.it/2016/06/new-ppc-media-center-version-6.html and then one need update to 6.5 from here http://www.mediafire.com/file/dxe9qre38pp2h3r/PPC_Media_Center_6.5.zip

mrkapqa commented 6 years ago

please see the attached PPC Media Center Script Marc Hoyois , it is freely usable according to Adam Albrec.

Archiv.zip

RandomDSdevel commented 6 years ago

@hoyois: Huzzah, you've returned from being MIA on GitHub! Sounds like you're still flummoxed, though, so I won't pull you any further into our babbling here. Good luck figuring out what's going wrong, though!


@mrkapqa: Cool, sounds like a possible lead for @hoyois to follow!

ghost commented 6 years ago

Don't know if this is a change in behavior, but the youtube killer appears broken again. This appears to have happened sometime in the past few days or week.

FWIW, I have both of these listed in my preferences [General->Plug-ins]

thx-- PP

RandomDSdevel commented 6 years ago

@ppmax: Yeah, that'd be this issue (as well as hoyois/plugin-to-html5#30 for reference's sake.) When you say 'FWIW, I have both of these listed in my preferences [General->Plug-ins],' though, what exactly do you mean by 'both of these,' both ClickToFlash and rg3/youtube-dl? Or both ClickToFlash and PPC Media Center? Or is it both ClickToFlash and nsfwyoutube?

ghost commented 6 years ago

@RandomDSdevel : Thanks for the reply.

Regarding your question: It looks like I forgot to paste in the links. In other words, when I show the clicktoplugin preference page in Safari, there is a textbook that you can add URI's to. In addition to the default killers, I also have the following: https://raw.githubusercontent.com/hoyois/plugin-to-html5/master/NYTimes.js https://raw.githubusercontent.com/hoyois/plugin-to-html5/master/YouTube.js https://raw.githubusercontent.com/hoyois/plugin-to-html5/master/CSSfix.js

This is all an overly pedantic way of saying "I think I'm using the latest YouTube and CSS killers" ;)

Thanks again, PP

RandomDSdevel commented 6 years ago

@ppmax: Ah, OK. I thought that the YouTube killer included CSSfix.js, so I just use the former.

vmachiel commented 6 years ago

So.. I think this is the end right?

RandomDSdevel commented 6 years ago

@vmachiel: Egads, I sure hope not! I just think @hoyois hasn't really had time to look into this in the right amount of detail yet.

a-greyyyyy commented 6 years ago

@vmachiel i hope not. anyone?

nabeelr commented 6 years ago

I'm kinda worried it's the end too... @hoyois ?

It's times like this I wish I had the stomach for coding, because then I would totally try to fix it for you all myself.

RandomDSdevel commented 6 years ago

@nabeelr:

It's times like this I wish I had the stomach for coding, because then I would totally try to fix it for you all myself.

Precisely! I have the stomach for it; I just haven't put the time in. (I'm currently carving some out to learn C++ and am planning on documenting my experience for myself using some LaTeX literate programming tools, so it'll be a while before I get around to web programming.)

RandomDSdevel commented 6 years ago

I'm not sure how, but watching videos through ProxySite's YouTube proxy still works, for what it's worth. Going to another website just to watch YouTube videos seems like overkill, though, especially this way…

a-greyyyyy commented 6 years ago

@RandomDSdevel

hmmmm... how odd. anyone notice the major revamps youtube has done to the UI the last few weeks? i wonder if that has something to do with clicktoflash/plugin no longer working.

RandomDSdevel commented 6 years ago

@a-greyyyyy: No, everything should be normal. That's either just ProxySite's custom player or you're not used to the new site design yet.