Libraries should be able to be created by subclassing ACLibrary instead of having to call generatedLibrary: - Githubissues

hpi-swa-teaching / AcceptIt

SWT 2018 Group 12

MIT License

3 stars 3 forks source link

Libraries should be able to be created by subclassing ACLibrary instead of having to call generatedLibrary: #36

Closed Askir closed 6 years ago

Askir commented 6 years ago

Story

AS A Developer I WANT TO be able to subclass ACLibrary IN ORDER TO Include already written Libraries and make the process smoother in general

Description

Why: (What value does it have? For whom?) subclassing just seems cleaner than the generateLibrary shit also have you seen that method?

What: (What should be implemented?) Instead of having to call `generateLibrary: xxxxxxx' I should be able to subclass ACLibrary with my own classes and just have to implement the necessary steps wihtout all the ugly overhead methods on class side etc.

Done: (How can it be demonstrated?) The Readme step by step should also change and work accordingly

Acceptance Criteria

[ ] generateLibraray becomes deprecated and subclassing ACLibrary is the new official methods
[ ] The Readme represents this change in the step by step
[ ] AcceptitGenerated becomes deprecated aswell

Estimation:

Jascha: This should maybe already be possible but it has to be tested to be official. I'd expect a 3 maybe a 5.

erksch commented 6 years ago

8

MarcelSchmidberger commented 6 years ago

5

Xhenet commented 6 years ago

5

Askir commented 6 years ago

This already works but needs some testing and cleanup in ACLibrary