hpi-swa-teaching / AcceptIt

SWT 2018 Group 12
MIT License
3 stars 3 forks source link

Remove unnecessary string manipulation. Fixes #39 #67

Closed Askir closed 6 years ago

Askir commented 6 years ago

Just another unnecessary withoutLeadingSubject that I removed. Tests are everything but clean right now though so plz dont merge, except if you badly need the bugfix.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 278


Files with Coverage Reduction New Missed Lines %
packages/acceptit-Core.package/ACScenarioCompiler.class/instance/grammar.st 3 0.0%
packages/acceptit-Core.package/ACUserStory.class/instance/stepLibraries.st 4 0.0%
packages/acceptit-Core.package/ACScenarioCompiler.class/instance/startRule.st 4 0.0%
packages/acceptit-Core.package/ACScenarioWrapper.class/instance/doesNotUnderstand..st 4 0.0%
packages/acceptit-Core.package/ACUserStory.class/instance/given..st 4 0.0%
packages/acceptit-Core.package/ACUserStory.class/instance/stepLibraries..st 4 0.0%
packages/acceptit-Core.package/ACUserStory.class/instance/stepsDone.st 4 0.0%
packages/acceptit-Core.package/ACUserStory.class/instance/when..st 4 0.0%
packages/acceptit-Core.package/ACScenarioWrapper.class/instance/initializeWithMethod..st 4 0.0%
packages/acceptit-Core.package/ACScenarioCompiler.class/instance/buildCode..st 4 0.0%
<!-- Total: 334 -->
Totals Coverage Status
Change from base Build 253: -25.3%
Covered Lines: 474
Relevant Lines: 1320

💛 - Coveralls
Askir commented 6 years ago

@erksch @Xhenet @MarcelSchmidberger Coverage testing was the issue, eveyrthing else is fine. Steps parse correctly now. The test is a little bit ugly but it does what it should and mocking Pragmas is pretty diffcult from what I've tried.