search

hpi-swa-teaching / AcceptIt

SWT 2018 Group 12
MIT License
3 stars 3 forks source link

Allow spaces in scenario titles. Fixes #73 #77

Closed Askir closed 6 years ago

Askir commented 6 years ago

Allows spaces in scenario titles. Works but now there is a popup with a warning. Can probably be disabled somehow but not sure how. Maybe just make a new issue for that? :D

Askir commented 6 years ago

Interesting this doesnt seem to work on Squeak 5.0 but works perfectly fine in our 6.0 and on 5.1

Askir commented 6 years ago

I found this in the squeak 5.1 release notes:

Compiler

  • Several fixes and clean-up in Compiler, Decompiler, Parser, and Encoder
  • Improved support for custom (Etoys) compilers
  • Add option to avoid interactive error correction when parsing and compiling code
  • Improves debugging support for optimized block temps

might be related

Askir commented 6 years ago

My fix would be to just remove 5.0 as target platform but maybe we should check with the teaching team first :D

MarcelSchmidberger commented 6 years ago

when saving a normal scenario, without white spaces, an error occures, but the scenario is saved correctly image

MarcelSchmidberger commented 6 years ago

When saving an scenario with a space in the name another error occures. With a note you are hinted that there may be a problem with the source files, but its fine just to say ok image (sorry for the delay totally forgot to send this comment after I have written it)

Askir commented 6 years ago

@MarcelSchmidberger I actually can't recreate the first issue you are having. Did you do anything else to that class beforehand?

MarcelSchmidberger commented 6 years ago

@Askir I am also not able to reproduce this error on a new squeak setup. I probably broke something within the old image... I think no further action is necessary