hpi-swa-teaching / AcceptIt

SWT 2018 Group 12
MIT License
3 stars 3 forks source link

Scenario rules triplication #92

Open Askir opened 6 years ago

Askir commented 6 years ago

Problem: What is wrong?

The ACScenarioGrammaer specifies the same rule three times which is implemented differently in the Semantic aswell. Specifically these three rules seem to be triplication: treeScenario fullScenario and annotatedTreeScenario.

ToDo: What has to be done?

  1. Figure out if these three rules are all even needed or if they can be replaced with each other
  2. Streamline their usage if they can be replaced
  3. Clean up the treeScenario and annotatedTreeScenario Semantic methods if you cannot remove them.
  4. In case they were not removed write some tests so that people who don't know what those methods can learn about them.

Explanation: Why? What value does it have?

Nobody really understand what these are for at the moment and they just seem to blow up the Semantic.

MarcelSchmidberger commented 6 years ago

Estimated: 5