hpi-swa-teaching / Interactive-Profiling

Interactive profiling
MIT License
6 stars 0 forks source link

Coding Standards #15

Open JakobEdding opened 7 years ago

JakobEdding commented 7 years ago
printOn: aWriteStream
"instead of"
printOn: aStream
simsieg commented 7 years ago

Commit Messages:

Reasons: Unified style, no decision effort

simsieg commented 7 years ago

Return style:

^ returnValue
"instead of"
^returnValue.

Reasons: readability, unified style

JakobEdding commented 7 years ago

I don't think that "Commit Messages" falls under the category Coding Standards. (On the same note: This is a nice guide to good Git commit messages that @FWirtz recommended to me some time back: https://chris.beams.io/posts/git-commit/)

simsieg commented 7 years ago

We noticed that our commit messages are not in an unified style and from now we want to be strict about our guidelines. In terms of documentation we commented this here to have a single source of process documentation.

flowirtz commented 7 years ago

Really am in favor of the guidelines I recommended to @jak-ing, they discuss several aspects and explain nicely why we should follow these standards. I do think though that "Commit Messages" are part of Coding Standards in an extended sense, as the Git workflow is the base of our coding work.

JakobEdding commented 7 years ago

Let's discuss this with Jonas on Tuesday, I understand coding standards to be specific to a programming language.