search

hski-github / spotfire-sankey-diagram

Spotfire mods visualization for Sankey diagram
MIT License
4 stars 4 forks source link

formattedValue() should not be used as an identifier #16

Closed hski-github closed 3 years ago

hski-github commented 3 years ago

formattedValue() should not be used as an identifier since it might have duplicates. Instead the key of the underlying hierarchy node should be used. formattedValue is meant for presentation.

hski-github commented 3 years ago

https://tibcosoftware.github.io/spotfire-mods/api-docs/interfaces/dataviewcategoricalvaluepathelement.html

hski-github commented 3 years ago

https://github.com/hski-github/spotfire-sankey-diagram/blob/e59b18981f1bfb51b8e741e4e48a8efea8db6618/src/main.js#L88-L98