hsuanxyz / ionic-tags-input

A ionic tags input component
https://stackblitz.com/edit/ionic-tags-input
MIT License
71 stars 24 forks source link

chore: update to ionic v4, #29

Open mixuala opened 5 years ago

mixuala commented 5 years ago

I'm not sure how to update your npm package, but these changes worked for my ionic 4 project

gezquinndesign commented 5 years ago

Hey @mixuala - any ideas how I can get your package into my project via npm? Thanks

mixuala commented 5 years ago

It's been a long time since I last built an NPM package. It's possible and if you know how, it's easy. But easier is just to add the component directly to your project.

On Thu, Mar 21, 2019 at 4:30 AM Gez Quinn notifications@github.com wrote:

Hey @mixuala https://github.com/mixuala - any ideas how I can get your package into my project via npm? Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HsuanXyz/ionic-tags-input/pull/29#issuecomment-475015867, or mute the thread https://github.com/notifications/unsubscribe-auth/Aed57Sz0WFx20DAmQRBunngcO40nzaMrks5vYpp9gaJpZM4a80j6 .

gezquinndesign commented 5 years ago

So, how do I get the component? I've ran the build script on your repo but it fails because it's looking for the Angular 4 references - should I update the package.json in your repo before building the package? Apologies for the noobiness.

mixuala commented 5 years ago

all my changes were in the /ion-tags-input folder. You can create a new ionic4 project and copy that folder to src/app/components/ion-tags-input/. I use this src/app/components/component.modules.ts for importing components:

import { NgModule } from '@angular/core';
import { CommonModule } from '@angular/common';
import { FormsModule, ReactiveFormsModule } from '@angular/forms';
import { IonicModule } from '@ionic/angular';

import { IonTag } from "./ion-tags-input/ion-tag";
import { IonTagsInput } from "./ion-tags-input/ion-tags-input";

@NgModule({
  imports: [
    CommonModule,
    FormsModule,
    IonicModule.forRoot(),
    ReactiveFormsModule,
  ],
  declarations: [
    IonTagsInput, IonTag,
  ],
  exports: [
    IonTagsInput, IonTag,
  ],
  entryComponents: [IonTagsInput, IonTag,],
})
export class ComponentsModule {}

then just import the ComponentsModule in any NgModule where you use the Component

something like this:

https://stackblitz.com/edit/ionic-v4-beta7-ion-tags-input

monsieurPaon commented 5 years ago

Up, it's possible to merge this please ??