Speedup rendering on huge graphs

htm-community / nupic.visualizations

Web application for interactive graphs, anomaly highlighting and online monitoring.

MIT License

17 stars 11 forks source link

Speedup rendering on huge graphs #25

Closed breznak closed 8 years ago

breznak commented 8 years ago

Fixes #16

update Dygraphs & friends to the latest versions
add CPU profiles in examples/debug (on Chromium v45, Ubuntu LTS, 64b)
add large file (100k rows) to test in examples/CSV
FIXed the extra slow zoom/rangeSelect in 4d945e6

breznak commented 8 years ago

@jefffohl please review, managed to fix this :smile: What needs to be done is updating the build/ folder, I've changed the requirements, but mine installs to ./node_modules/

jefffohl commented 8 years ago

Thanks @breznak I have some time today to get back into this. I will take a look at your PRs.

breznak commented 8 years ago

@jefffohl :+1: thanks

jefffohl commented 8 years ago

@breznak I am not sure what you mean by, "... mine installs to ./node_modules/"? Do you mean you are having a problem with using gulp?

Also, bower packages should be a part of the PR. In case you don't know - bower is a kind of package manager for web apps. In order to install your updated versions of bower packages, go to /client and run bower install. Then, commit your changes.

Usually, I include bower packages as part of a repo, because they are not specific to the developer's machine - but I do not include node_modules because those contain binaries meant to run only on the development environment.

breznak commented 8 years ago

@jefffohl

In order to install your updated versions of bower packages, go to /client and run bower install.

That was exactly my question. I think the dev. setup works for me, I follow the readme, run npm install and gulp in the nupic.visualizations/ ..and stuff updates :wink: I was aware I need to actually commit the updated libs, but didn't know how to get them. Will do now. Should I also add node_modules/ to .gitignore so it does not bother?

breznak commented 8 years ago

@jefffohl that should be it :+1: Thanks for the advice!

jefffohl commented 8 years ago

@breznak This looks good, thanks! A couple of notes:

What are the /examples/debug/ files for?
It would be good to add some kind of user feedback after clicking the "Render" button. On huge files, there is a long pause, and we want the user to know that they should wait. I will make a new issue for that.

Feel free to merge the PR.

breznak commented 8 years ago

Thanks @jefffohl !

examples/debug are CPU profiles from chromium, I used them to debug the speed issue. Maybe we can remove them later, but I think we'll use them (or newer) for handling really large files (1M+ points).