Open breznak opened 8 years ago
Thoughts @jefffohl @rhyolight ?
@breznak said:
It is perfectly legal for the new sequence to have a different/older timestamp than the previous sequence.
@scottpurdy Is this true?
What code are we talking about here? In the OPF, it is perfectly valid to have resets and older timestamps afterward. But what graph are we talking about?
@scottpurdy just visualization specific problem here. For DyGraphs we need functions (one fn value at given time), OPF with resets does not ensure that, so we should represent the data differently, not plotted as function of time, but as fn of iteration number(step).
Ahh got it. Yes that sounds right. We should use the record number for the x-axis and timestamps just as labels.
Thanks @scottpurdy
Reopening for discussion if we should :
Problem: For example OPF files have a
reset
field which annotates a new sequence starts. It is perfectly legal for the new sequence to have a different/older timestamp than the previous sequence. This is detected as non-monotonicity in time and causes the graph to be incorrectly rendered.Solution:
hasResets
, the timestamp is ignored and we use iterations.Note: