search

hubspotdevops / puppet-nexus

Puppet module for Sonatype Nexus
MIT License
24 stars 93 forks source link

Added the ability to configure JVM options (i.e. setting memory heap size) #108

Closed leewilson86 closed 4 years ago

leewilson86 commented 5 years ago

Currently, there is no way to configure JVM settings for Nexus with this module.

An update has been added to allow setting various JVM settings. Example hiera below:

nexus::vmoptions :
  jvm-xmx:
    match: '^-Xmx'
    line: '-Xmx2703M'
  jvm-xms:
    match: '^-Xms'
    line: '-Xms2703M'
  jvm-max-direct-memory-size:
    match: '^-XX:MaxDirectMemorySize'
    line: '-XX:MaxDirectMemorySize=2703M'

This effectively configures: "${nexus_root}/${nexus_home_dir}/bin/nexus.vmoptions" using file_line from the Puppet standard library.

leewilson86 commented 5 years ago

Hi,

Would someone be able to review my PR please? Thanks

leewilson86 commented 5 years ago

Hi @pranav.

Have you had a chance to review this Pull Request?

It would be great to have your feedback on this as I am sure it is a very useful addition.

Thanks

Nevoff89 commented 5 years ago

@leewilson86 Thanks for contribute. I'm looking forward to seeing this feature in master

leewilson86 commented 4 years ago

@tykeal is this project now dead?

tykeal commented 4 years ago

@leewilson86 wow... I just saw this comment while cleaning up my mailbox (shows how bad my personal mailbox has gotten).

I dunno why you're asking me if this project is dead. I have no control over the hubspotdevops repos...

I would almost hazard a yes though given that there has been no code merges since 2018.

kenbreeman commented 4 years ago

https://github.com/hubspotdevops/puppet-nexus#-no-longer-maintained-

tykeal commented 4 years ago

@kenbreeman well, I guess that answers the question from @leewilson86

Thank you for having made a good module, sorry you aren't maintaining it anymore but I totally get that!

leewilson86 commented 4 years ago

This project is dead. So I am closing my PR. I have a fork which has this solution for me.