Fix up the basic initial spec tests

hubspotdevops / puppet-nexus

Puppet module for Sonatype Nexus

MIT License

24 stars 93 forks source link

Fix up the basic initial spec tests #48

Closed tykeal closed 8 years ago

tykeal commented 9 years ago

Get the original spec tests passing.

This adds in two different spec contexts:

no params defined for the nexus class
- this is essentially what the tests were at first but they were failing due to not catching the thrown exception
with a version set and nothing else
- this is essentially what the tests were trying to basically evaluate before my modifications but were failing
- This required some modifications to nexus::service and a minor clean-up of how resources were declared / chained in the base nexus class.

Signed-off-by: Andrew Grimberg agrimberg@linuxfoundation.org

tykeal commented 9 years ago

Just curious if there is a problem with this PR? I've got more to start sending in to a) get the module workable in Travis-CI b) clean up some of the puppet lint issues and c) add options for the module to be able to install nexus-pro

tykeal commented 9 years ago

I'll see what I can do. I had weird issues with the tests not passing properly when I had it in the previous configuration.

tykeal commented 8 years ago

Finally getting back this. Anything I can do to get this merged? I want to add in the ability to manage deploying Nexus Pro but I won't be able to test my changes if we don't fix the rspec!

tmclaugh commented 8 years ago

lgtm. I have no access to merge anymore though.

@pranav or @kenbreeman?

pranav commented 8 years ago

:rocket:

tykeal commented 8 years ago

Much appreciated! I should have PR for Nexus Pro management later today :) As an FYI with these changes now merged I would encourage y'all to consider setting up Travis-CI build verification: https://travis-ci.org/