search

hubspotdevops / puppet-nexus

Puppet module for Sonatype Nexus
MIT License
24 stars 93 forks source link

[WIP] Add support for 'puppet-archive' download provider #84

Open fatmcgav opened 7 years ago

fatmcgav commented 7 years ago

[WIP] Add support for puppet-archive download provider in addition to maestrodev-wget.

We currently use puppet-archive for the majority of our downloads, so rather than adding another download module to our site, lets add support for puppet-archive to this module :)

Raising early to get feedback on changes etc...

To-do:

tmclaugh commented 7 years ago

Please don't muddle this module with choose your own adventure resource types. If there's a need to use a different module then explain the issue. If the issue is specific to you then fork this rather than complicating the code for others. As far as I can tell the only issue is your site does not wish to add an additional dependency which IMHO is not worth the added complication for everyone else that uses or has to support this.

kenbreeman commented 7 years ago

I appreciate the initiative and puppet-archive looks like a nice module with some decent features, but I agree with @tmclaugh that switching to this module doesn't add significant value to puppet-nexus.

fatmcgav commented 7 years ago

@tmclaugh / @kenbreeman Thank-you for the quick responses.

My reasoning is above; as far as I'm concerned removing the need for another module just for downloading a file is sufficient. The pattern of supporting different 'download' providers is in use by several other modules that we consume from the forge, and works great.

The 'interface' changes for anyone consuming, or wanting to consume the module, is a single new class param, which defaults to the current behaviour of using maestrodev-wget.

Yes, I'd agree that there's slightly more complexity in the nexus::package class, but that's all self-contained and the code itself is pretty easy to read and understand...

fatmcgav commented 6 years ago

Any appetite to revisit the above decision and add this additional functionality for the wider benefit?

logichard commented 5 years ago

Hello, I think you should just change download module to puppet-archive because maestrodev-wget is deprecated and author of maestrodev-wget recommended to use puppet-archive. @fatmcgav if u want i can make a PR with this change.