search

huggingface / huggingface.js

Utilities to use the Hugging Face Hub API
https://hf.co/docs/huggingface.js
MIT License
1.42k stars 230 forks source link

Update peft code snippet #1047

Open not-lain opened 2 days ago

not-lain commented 2 days ago

The peft code snippet loads a PeftConfig parameter which is not used anywhere, I think it would be better to remove that since the entire script functions without it. cc @BenjaminBossan if you have any inputs about this.

image

image

BenjaminBossan commented 1 day ago

Yes, I agree, it's not necessary as PeftModel.from_pretrained loads the config automatically. Are you interested in creating a PR to remove this line @not-lain?

not-lain commented 1 day ago

Hi @BenjaminBossan Thanks a lot for your prompt reply, I would love to take this issue