huggingface / huggingface.js

Utilities to use the Hugging Face Hub API
https://hf.co/docs/huggingface.js
MIT License
1.42k stars 229 forks source link

Missing Type From the Inference Package #584

Open abdel-17 opened 7 months ago

abdel-17 commented 7 months ago

In the types of the @huggingface/inference package, the textGeneration function is declared as follows

export function textGeneration(
    args: BaseArgs & TextGenerationInput,
    options?: Options
): Promise<TextGenerationOutput>;

But the TextGenerationOutput type is missing from the file, so the return type is inferred as any by TypeScript.

In the source code, the TextGenerationOutput type is imported from this file in a separate package, which does correctly have the type, so this is likely an issue with the build step.

coyotte508 commented 7 months ago

Ah yes indeed cc @SBrandeis

Current typing is generated in generate-dts.ts for the inference package, would need to modify the script. Maybe call tsup with --dts-resolve as a first step and then our custom stuff.