search

huggingface / huggingface.js

Utilities to use the Hugging Face Hub API
https://hf.co/docs/huggingface.js
MIT License
1.4k stars 224 forks source link

Rm ArrayBuffer.resize polyfill when Firefox supports it by default #642

Open mishig25 opened 6 months ago

mishig25 commented 6 months ago

from https://github.com/huggingface/huggingface.js/pull/638#issuecomment-2079454125

According to caniuse page, the support is experimental on version 124 (current version) of firefox (can be enabled via a flag). So I think it's expected to be stable on 125. Unfortunate I couldn't find the issue tracker anywhere so I can't confirm that information.

In any way, I feel like this API is relative new on all other browsers, so it's maybe better to keep this polyfill for a while.

cc: @ngxson @julien-c

ngxson commented 6 months ago

A small correction is that I'm not sure if Firefox 125 will have it enabled by default or not. Would you mind to change the title for clarification @mishig25 ? Something like: Rm ArrayBuffer.resize polyfill when Firefox supports it by default

Thanks in advance.

mishig25 commented 6 months ago

done so 👍

ngxson commented 6 months ago

Update Firefox 125 is out, but support for .resize is still experimental: https://caniuse.com/?search=ArrayBuffer.resize

mishig25 commented 6 months ago

but support for .resize is still experimental

let's keep the polyfill until .resize is in stable mode