huguesrichard / Allopipe

AlloPipe is a computational method to assess the alloreactivity expected from a donor/recipient transplantation pair
MIT License
0 stars 0 forks source link

AMS multiprocess overwrite #7

Closed PierreLaville closed 7 months ago

PierreLaville commented 7 months ago

When running a second time multiprocess_ams.py on a folder with the same [run_name]:

The '[run_name]' directory already exists and contains an AMS directory with the same run parameters. Do you wish to overwrite ? [y/N] The '[run_name] directory already exists and contains an AMS directory with the same run parameters. Do you wish to overwrite ? [y/N] The '[run_name]' directory already exists and contains an AMS directory with the same run parameters. Do you wish to overwrite ? [y/N]

Consequences:

This is really a minor issue but still worth to be at least reported. The easiest fix being of course not choosing the same [run_name] as before.

PierreLaville commented 7 months ago

This is actually not such a minor issue as I expected: this happens also in a single run when the number of pairs is superior to the nb of threads (4 for instance). The 4 first pairs run and then the "Do you wish to overwrite ? [y/N]" appears, get filled with the rest of the pairs output which never can be computed causing the script to get stuck and never end.

huguesrichard commented 7 months ago

ah yes, this is annoying, I would advise we take out this interactive setup and put a mechanism in place for avoiding to overwrite files and run everything as a multiprocess.