huguesrichard / Allopipe

AlloPipe is a computational method to assess the alloreactivity expected from a donor/recipient transplantation pair
MIT License
0 stars 0 forks source link

Fasta parsing resistant to v.37 #9

Closed huguesrichard closed 2 months ago

huguesrichard commented 4 months ago

The code to parse the peptidic information is constrained to GRCh38, we should make that more generic (GRCh37), in particular at this line:

https://github.com/huguesrichard/Allopipe/blob/e3422e2895b1df58be38f1546265b067f4fde698/src/tools/parsing_functions.py#L392

PierreLaville commented 3 months ago

See part of the solution in changes pushed unintentionally in src/tools/aams_helpers.py

huguesrichard commented 3 months ago

Good if that can be adressed in a more general way. However I did not find the change in the ams_helper.py file that is responsible for it. Could you give me the line?

PierreLaville commented 3 months ago

Changes were actually in aams_helpers.py and not in ams_helpers.py but reverted to previous version in this commit. All changes related to this issues were made here.