Last working config? - Githubissues

ntinti commented 4 years ago

Whats the last working config on debian This one ? ####################################### set_core_regex='cp-6.0$' set_online_regex='collabora/collabora-online-4-0-4$' lo_src_branch='distro/collabora/cp-6.0' lo_src_tag='cp-6.0-30' #######################################

joergmschulz commented 4 years ago

lo_src_tag='cp-6.0-31'

titansmc commented 4 years ago

I have this one:

About

LOOLWSD 4.0.8 (git hash: 2fc9aba)

LOKit Collabora OfficeDev 6.0-31 (git hash: 9e571fc)

joergmschulz commented 4 years ago

how did you get 4.0.8 included? could you please add the necessary lines in the .cfg? Thank you

titansmc commented 4 years ago

#### default set is latest version of collabora
#set_name='distro/collabora'
## set_core_regex & set_online_regex are regulax expression used to find the branch name for core and online
## example:
set_core_regex='cp-6.0$'
set_online_regex='collabora-online-4-0$'
## set_version can be used if both branch name contains a common version number
## if empty, latest version available for each project will be used
set_version='cp-4.0.8-2'

#### LibreOffice parameters ###
#lo_src_repo='https://github.com/LibreOffice/core.git'
lo_src_branch='distro/collabora/cp-6.0' # a existing branch name. # THIS WILL be overriden by the set branch
#lo_src_commit='' # the short/full id of a git commit
lo_src_tag='cp-6.0-34' # a tag in the repo git
lo_dir="/home/suite/libreoffice"
#lo_forcebuild=false # force compilation
#lo_req_vol=11000 # minimum space required for LibreOffice compilation, in MB
#lo_mini=true
#lo_configure_opts='' #comma separated options names
lo_non_free_ttf=true # add Microsoft fonts to Ubuntu

#### POCO parameters ###
poco_version=$poco_version_latest #latest releases available
poco_dir="/home/suite/poco-${poco_version}-all"
#poco_forcebuild=false
#poco_req_vol=550 # minimum space required for Poco compilation, in MB

#### LibreOffice Online parameters ###
lool_src_repo="https://github.com/LibreOffice/online.git"
#lool_src_branch='distro/collabora/collabora-online-4' # a existing branch name. # THIS WILL be overriden by the set branch
#lool_src_commit='' # the short/full id of a git commit
#lool_src_tag='' # a tag in the repo git

titansmc commented 4 years ago

unstable... I will try with Ubuntu 18.04

titansmc commented 4 years ago

Ubuntu 18.04 seems to not crash, although I still get a lot of those errors:

loolwsd[83771]: kit-83813-83833 2019-11-28 12:43:27.416854 [ kitbroker_002 ] ERR  Unknown callback event (44): {}| kit/ChildSession.cpp:2223

on every click in the LOOL

quenenni commented 4 years ago

Hello,

Thanks a lot for this post. Very nice to know the last working configuration.

I succeeded to have it working on a Debian 10 (Buster) with the default script options for the core repo and poco, but I had to pause the script for the online repo and change manually to another branch before continuing.

Core: 02b9ea64850f33df7b3c89c24a2cafbaeab0f85b (HEAD -> distro/collabora/cp-6.2, tag: cp-6.2-3, tag: CODE-4.2.0-3)
Poco: v1.9.4
Online: git checkout distro/collabora/collabora-online-4-0

My Lool is working with this info in the about section:

LOOLWSD
4.0.9 (git hash: 956c17af)
LOKit
Collabora OfficeDev 6.2-3 (git hash: 02b9ea6)

From that, here I think is the right translation for the config:

set_core_regex='cp-6.2$'
set_online_regex='collabora-online-4-0$'

#### LibreOffice parameters ###
lo_src_branch='distro/collabora/cp-6.2'
lo_src_tag='cp-6.2-3'

#### LibreOffice Online parameters ###
lool_src_branch='collabora-online-4-0'
lool_src_commit='956c17afe9d5e33f53fd8d107e8384520e23d862'

Maybe first check without setting the commit id to test with the most recent one.

joergmschulz commented 4 years ago

Yes. This config looks good and is working. BUT: I don't see spell checking suggestions (right-mouse). Which is an improvement - other 6.2 versions stopped working on right-mouse click. So, the best functional version might be 6.0 until further notice.

quenenni commented 4 years ago

I'm in the process of testing lots of different commits because I discovered that in the branch 6.2, there is a bug in the calc spreadsheets. I already tested the branch 6.0 up to the last commit and it's good. (with the online at v4.0.10)

As soon as I finished my tests, I'll put here my result.

I have no idea about the spell checlking thingy. I'll keep an eye in my next tests.

Ark74 commented 4 years ago

@quenenni hello! I'm running the 6.2 branch, what bug do you refer to?

quenenni commented 4 years ago

The column and line headers are wrong, all not on top of their own column / line.

The most recent commit I found without the bug is https://github.com/LibreOffice/core/commit/60da17e045e08f1793c57c00ba83cdfce946d0aa. And couple tags later, the problem is there. I'm testing them around to try to pin point the commit more precisely.

It seems i can't upload a small picture on github to visualize the problem so here is a link to it: https://pasteboard.co/IRlD2Vu.jpg (sorry for the bad quality, but you can see the wrong headers)

And the problem is present up to a very recent commit (commit from before yesterday).

joergmschulz commented 4 years ago

Indeed, reproducible:

LOOLWSD 4.0.4 (git hash: 305832f8) LOKit Collabora OfficeDev 6.2-3 (git hash: 02b9ea6)

quenenni commented 4 years ago

My last tests showed:

Commit https://github.com/LibreOffice/core/commit/60da17e045e08f1793c57c00ba83cdfce946d0aa is good.
Commit https://github.com/LibreOffice/core/commit/d92a38e36872a8ca4f44483f73a8a0d12dbf2803 has the problem.

joergmschulz commented 4 years ago

@quenenni: so which settings did you put into the config?

quenenni commented 4 years ago

As it seems the script has problems when using the vars "lo_src_tag" or "lo_src_commit" (the repo is not at the right commit / tag when compiling LO sometimes, I had few errors), I decided to do it manually.

I commented 3 lines in the script that search and set the repo to the right commit (bin/corePrep.sh).

#eval "$(SearchGitCommit $SearchGitOpts)"
#if [ -d ${lo_dir}/instdir ] && $repChanged ; then
lo_forcebuild=true
#fi

I cloned manually the LO repo, then set the right commit
```
git checkout distro/collabora/cp-6.2
git pull
git checkout 60da17e045e08f1793c57c00ba83cdfce946d0aa
(and git log to check that you're at the right commit)
```
- For the online part: The last commit, "Bump package version to 4.0.10-1" (Mon Jan 20 23:30:44 2020) is working well. You have to configure the officeonline-install.cfg file like this:
```
set_version='cp-4.0.10-1'  (not sure this one is compulsory)
lool_src_branch='distro/collabora/collabora-online-4-0'  (this one is compulsory)
```
  If you let the default values, the script won't go on the 4-0 branch but the 4 and it will fail.
- For the Poco part, I let the script use the default values and it works. For my tests here, the script used the poco-1.9.4-all

PS: I also tried to compil Lool on the 6.0 branch at the last commit (2, 3 days ago) and it was working.. in case you prefer to stay on the 6.0 branch.

quenenni commented 4 years ago

Yes. This config looks good and is working. BUT: I don't see spell checking suggestions (right-mouse). Which is an improvement - other 6.2 versions stopped working on right-mouse click. So, the best functional version might be 6.0 until further notice.

@joergmschulz I checked the spell checking suggestions. By default, I had only en_US dictionnary available. I installed the packages hunspell-fr & hunspell-nl (apt install hunspell-fr hunspell-nl), restart loolwsd service and now have the new dictionnaries available.

The auto suggestions (the red wave under the words) is working. Then the right click on it opens a suggestion list.

All seems good to me on the 6.2 branch.

joergmschulz commented 4 years ago

confirming - the following works well with all the changes @quemenni suggested.

Filenames containing a % can be opened
cell indicators work on calc documents
spellchecking works.

lo_src_repo='https://github.com/LibreOffice/core.git'

lool_configure_opts='--disable-werror'
set_version='cp-4.0.10-1'  

lool_src_branch='distro/collabora/collabora-online-4-0'

lo_src_branch='libreoffice-6-3-4' # a existing branch name. # THIS WILL be overriden by the set branch
lo_src_commit='60da17e045e08f1793c57c00ba83cdfce946d0aa' # the short/full id of a git commit
lo_src_tag='libreoffice-6-3-4' # a tag in the repo git
lo_forcebuild=false # force compilation
lo_non_free_ttf=true # add Microsoft fonts to Ubuntu
poco_version=$poco_version_latest #latest releases available
lool_src_repo="https://github.com/LibreOffice/online.git"
lool_src_branch='distro/collabora/collabora-online-4-0' # a existing branch name. # THIS WILL be overriden by the set branch

Ark74 commented 4 years ago

Thanks for the info. On my part I would suggest that you want to avoid poco-1.9.10, seems to break compilations atm. Cheers!

quenenni commented 4 years ago

@joergmschulz Can you tell me what the option "--disable-werror" is doing?
I never used it.

joergmschulz commented 4 years ago

at one time when buster had been new, compilation failed without this flag. Some compiler warnings had been elevated to errors.

Ark74 commented 4 years ago

@joergmschulz seems this has been fixed in 6.2-4: https://gerrit.libreoffice.org/plugins/gitiles/core/+/24c4f84c33cef84672a37810009081cd6fca5309

rwagnon commented 4 years ago

Does this mean that the latest working can be moved to 6.2?

quenenni commented 4 years ago

I'd say yes for me. It's been working on production for nearly a month without problems on my side.

rwagnon commented 4 years ago

In 6.2, I get spreadsheet rows that are compressed in the selection area, but normal in the working area:

joergmschulz commented 4 years ago

yes. This is why the op.cit. version has been proposed as a good one.

rwagnon commented 4 years ago

What do you mean op.cit. version?

Should the script code changes be checked into github?

rwagnon commented 4 years ago

With the 3 script code comments and the config file listed, is this necessary: "cloned manually the LO repo"?

quenenni commented 4 years ago

You don't need to manipulate the files, try to modify the config file like in this comment: https://github.com/husisusi/officeonlin-install.sh/issues/188#issuecomment-578742358

rwagnon commented 4 years ago

I got this, which I see has a workaround: configure: error: unrecognized options: --disable-kde4

https://github.com/husisusi/officeonlin-install.sh/issues/181

Ark74 commented 4 years ago

In 6.2, I get spreadsheet rows that are compressed in the selection area, but normal in the working area:

@rwagnon if you mix online 4.0 + core 6.2 seems to be a common issue.

I believe it's a good idea to stick with these combinations,

6.0.x + 4.0.x
6.2.x + 4.2.x

Since they seems to be what upstream supports.

rodrigoesborges commented 4 years ago

Has anybody been able to compile collabora 4.2.0.4 already on Debian Buster?

dieg0nob commented 4 years ago

how can i compile libreoffice 6.2 + 4.2 with all translations? someone knows? i have only lang english

Ark74 commented 4 years ago

@dieg0nob check https://github.com/husisusi/officeonlin-install.sh/issues/169

joergmschulz commented 4 years ago

@dieg0nob : So you have a working config for 6.2 and 4.2? Does this version run without my favorite bugs? Can you add your best .cfg entries here?

% sign in filenames
garbled view in .xls
right mouse click for dictionary access

dieg0nob commented 4 years ago

@dieg0nob : So you have a working config for 6.2 and 4.2? Does this version run without my favorite bugs? Can you add your best .cfg entries here?

% sign in filenames

garbled view in .xls

right mouse click for dictionary access

this bug are not present in my install in debian buster here my settings in officeonline-install.cfg:

lo_src_branch='distro/collabora/cp-6.2' lo_src_tag='cp-6.2-5' lool_src_branch='distro/collabora/co-4-2-0' lool_src_tag='CODE-4.2.0-6' lool_configure_opts='--with-lokit-path=/opt/libreoffice/include'

(I need to set lool_configure_opts because in the compile, show me error and tell me to set this var)

My query is how I would have to do to translate the loolwsd, because as seen in the image, a part is in Spanish and the right panel and other things in English collabora

Ark74 commented 4 years ago

Hmm, good point. Not sure then, maybe you'll like to check the build options I linked before, maybe they can be tweaked.

Also, I'm guessing that this bar is brand new for the Online version so maybe there is no l10n work yet.

dieg0nob commented 4 years ago

Hmm, good point. Not sure then, maybe you'll like to check the build options I linked before, maybe they can be tweaked.

Also, I'm guessing that this bar is brand new for the Online version so maybe there is no l10n work yet.

I figured out how to translate everything into Spanish, I had to modify the file lib/default.cfg where it says with-lang= by with-lang=es and then it has downloaded a lot of languages and now it shows me everything in Spanish completely. also i had to force it to compile again with lo_forcebuild=true in officeonline-install.cfg

Ark74 commented 4 years ago

i had to force it to compile again with lo_forcebuild=true in officeonline-install.cfg

./officeonline-install.sh -f lo

Has the same effect.

it shows me everything in Spanish completely.

Nice to know, I wonder if more than one language can be added so the browser can select the language, or if it's hardcoded.

dieg0nob commented 4 years ago

Nice to know, I wonder if more than one language can be added so the browser can select the language, or if it's hardcoded.

i think if you set with-lang=ALL do the trick, in the future i will test it.

husisusi commented 4 years ago

@dieg0nob : So you have a working config for 6.2 and 4.2? Does this version run without my favorite bugs? Can you add your best .cfg entries here?

% sign in filenames

garbled view in .xls

right mouse click for dictionary access

this bug are not present in my install in debian buster here my settings in officeonline-install.cfg:

lo_src_branch='distro/collabora/cp-6.2' lo_src_tag='cp-6.2-5' lool_src_branch='distro/collabora/co-4-2-0' lool_src_tag='CODE-4.2.0-6' lool_configure_opts='--with-lokit-path=/opt/libreoffice/include'

(I need to set lool_configure_opts because in the compile, show me error and tell me to set this var)

My query is how I would have to do to translate the loolwsd, because as seen in the image, a part is in Spanish and the right panel and other things in English

### Your configuration does not work on Ubuntu 18.04! grafik

dieg0nob commented 4 years ago

### Your configuration does not work on Ubuntu 18.04!

your version off loolwsd is 4.1.0 in the screenshot, i'm using 4.2.0-6

husisusi commented 4 years ago

your version off loolwsd is 4.1.0 in the screenshot, i'm using 4.2.0-6

Could you please post your LOOLWSD version screenshot?

joergmschulz commented 4 years ago

set_online_regex='collabora/code-4.2' lo_src_branch='distro/collabora/cp-6.2' lo_src_tag='cp-6.2-5' lool_src_branch='distro/collabora/code-4.2.0-4' lool_src_tag='CODE-4.2.0-4' lool_configure_opts='--with-lokit-path=/opt/libreoffice/include --disable-werror'

husisusi commented 4 years ago

@joergmschulz Thank You! Interessant! Ich benutze die gleiche Konfiguration! Aber taucht LOOLWSD 4.1.0 auf!!! Vorher war die 4.0.0!

husisusi commented 4 years ago

@joergmschulz Thank You! I will chack...

joergmschulz commented 4 years ago

@husisusi : hmmm, sollte nicht. Hatte ich auch bei einigen build Versuchen. Schau mal in den logs nach, ob irgendwo master gezogen wird statt der korrekten branches.

husisusi commented 4 years ago

Yes, it was the wrong branch. It works correctly now! grafik

ntinti commented 4 years ago

I have to set "lool_forcebuild=true" Building works like a charm. Thanks to all! The spreadsheet app seems to be a little buggy.

joergmschulz commented 4 years ago

which bugs are worth to be mentioned?

rodrigoesborges commented 4 years ago

Great, just compiled with same config. Has anybody tried 6.2-6 already? 4.2.0-4 , officedev 6.2-5

husisusi / officeonlin-install.sh

Last working config? #188