Fix/cog unloading - Githubissues

hwsuk / discord-bot

Multi-purpose Discord bot for the HWSUK Discord server

2 stars 1 forks source link

Closed issy closed 4 years ago

issy commented 4 years ago

Move DB task to subroutine This allows you to use bare exceptions without it locking the event loop on sig calls
Use db.collection.find() instead of db.collection.watch() This also locks the event loop on sig calls
Cancel task on cog unload This isn't entirely necessary and doesn't actually introduce any performance benefits, but it's good practice

Overall this reduces service kill time from 1m30s to 0-2 seconds

issy commented 4 years ago

I still need to test the queue monitoring with some verification events and debug points to make sure it's watertight

issy commented 4 years ago

This has now been tested and the queue monitoring works