search

hydescarf / Obsidian-Theme-Mado-11

A simple theme that makes Obsidian feels a bit more like a modern app.
MIT License
75 stars 3 forks source link

iframes with style position:absolute are not working #13

Closed nilssrvd closed 1 year ago

nilssrvd commented 1 year ago

I took it upon myself to check that those iframes are working in all the other Obsidian Themes and so it is; it's possible to embed iframes in the entirety of a note. Not on Mado 11. The note just appears empty in reading mode. I have no idea what could be causing this, but it's unique to this Theme as far as I know.

Here is a simple line of HTML code to test the functionality:

<iframe src="https://es.wikipedia.org/wiki/Biblia" style="position:absolute; top:0; left:0; width:100%; border:none; height:100%;"></iframe>

That said, let me tell you that your work with this Theme is fabulous, the best I've seen in styling for Obsidian.

hydescarf commented 1 year ago

I assume you are currently on <v0.16, as Mado-11 is disabled for v1.0.
My app has auto-updated to the latest version now, so I might as well just rewrite the code for v1.0 and look out for the iframe issue. Thanks for the report!

nilssrvd commented 1 year ago

I assume you are currently on <v0.16, as Mado-11 is disabled for v1.0.
My app has auto-updated to the latest version now, so I might as well just rewrite the code for v1.0 and look out for the iframe issue. Thanks for the report!

I am also on v1.0. Since Mado isn't listed there as a Legacy Theme, I assumed it was already updated to work with v1.0. I imagine that this may be in fact a problem associated with the aforementioned update. Hoping my report will help you!

hydescarf commented 1 year ago

The theme is now updated to v1.0. Although I didn't find any issue occurring on v1.0 (with both old and new version of the theme), let me know if it persists. If anything, I do notice the lag of loading which causes the reading mode to be empty, for a few seconds.

nilssrvd commented 1 year ago

The theme is now updated to v1.0. Although I didn't find any issue occurring on v1.0 (with both old and new version of the theme), let me know if it persists. If anything, I do notice the lag of loading which causes the reading mode to be empty, for a few seconds.

This is great, thank you. The problem I mentioned before seems to be completely resolved now.

There is anyway a problem with this bottom bar in the next picture. Do you know what could be causing it? Or is it not a problem since Mado 11 is just not coded to show it?

Problem bottom bar.png

Of course, when I hover over the bar's location with the mouse it doesn't appear, which could not be seen in the image.

hydescarf commented 1 year ago

Glad to hear the issue is resolved! Oh yeah, status bar is now hidden by default (and not hover-able), it can be toggled to be shown all time through Style Settings.

hydescarf commented 1 year ago

I'll close this issue now as the main problem is resolved!