search

hydescarf / Obsidian-Theme-Mado-11

A simple theme that makes Obsidian feels a bit more like a modern app.
MIT License
75 stars 3 forks source link

[Request] to avoid/remove !important for page width setting #2

Closed efemkay closed 2 years ago

efemkay commented 2 years ago

your inclusion of !important to increase specificity is interfered with collection of snippets. hope you can consider not using !important for this. this is because, if i understand correctly, i can only override it by having an !important and then put more css classes. in this case, i have a snippet to control with of specific pages and if i use ur theme, the snippet can no longer work.

perhaps u use doubling of last class e.g. .markdown-preview-view.is-readable-line-width .markdown-preview-sizer.markdown-preview-sizer for you to override app's default css (in fact i believe, even with same specificity, snippets take priority).

thank you. btw i really love the clean look of your theme.

image

hydescarf commented 2 years ago

Thank you for the heads up! Upon investigating, the !important was not important to the "preview" and multiple classes did the trick for "source". I will also continue fixing the rest of the code that has !important in it in a few hours, though some of them have to use it to override inline class by Obsidian.

And thank you for the like ❤️

hydescarf commented 2 years ago

Most of the !important elements are now removed in the latest update: https://github.com/hydescarf/Obsidian-Theme-Mado-11/commit/c3cf44bacdb6ed7769d7adfedbdf212887d9d424 Some are kept as to override Obsidian inline-styling:

I have also changed the part for the note padding (especially source-view)

.markdown-preview-view{
    padding-inline:63px;
}
.markdown-source-view .cm-content{
    padding-inline:13px;
}

It might affect your WIP snippets, so just a head up in case something changes on your side.

Let me know if these work well for you!

Edit: Closing issue! Feel free to open it back up if you're having problem with the remaining !important.

efemkay commented 2 years ago

Thanks! Sorry only managed to test it just now. Works fine with my snippet now. Appreciate it!