search

hynek-urban / rocketchat-async

asyncio-based Python wrapper for the Rocket.Chat Realtime API.
MIT License
11 stars 9 forks source link

Update/subscribe to channel changes #11

Closed kato-mahiro closed 1 week ago

kato-mahiro commented 2 months ago

Related issue #10

I have updated the subscribe_to_channel_changes method to detect when the user joins a new channel or DM and when a file is uploaded to a channel they are part of. However, it does not detect other events such as being kicked from a channel or other users joining.

Additionally, there is a known issue where the method uses lastMessage for detection, which results in multiple file_added events being detected if the lastMessage involves a file upload.

I acknowledge this method is not ideal, but it is an attempt to make it more useful.

hynek-urban commented 1 month ago

@kato-mahiro Thank you :) I'll try to test it and will let you know. (But you know me already, it can take me an additional week or two.)

kato-mahiro commented 1 month ago

@hynek-urban Thank you for the comment. I’ve been reviewing this commits and thinking, maybe it would be more sophisticated to add a raw version to the SubscribeToChannelChanges class as suggested in #12 . Would you mind if I give it a try? If so, feel free to close this issue.

hynek-urban commented 1 week ago

@kato-mahiro I went with the approach in the MR you've linked above and added the subscribe_to_channel_changes_raw method. If I understand it correctly, that should cover the original motivation behind this MR so let's close it. Thanks for the suggestion and sorry for the delay!