hyperf / socketio-server

[READ ONLY]
MIT License
21 stars 6 forks source link

不要全部都private,这样无法通过继承小量替换方法了 #32

Open aogg opened 1 day ago

aogg commented 1 day ago

如题

aogg commented 1 day ago

比如下面代码应该改为受保护的,而不是私有的


    private function dispatch(int $fd, string $nsp, string $event, ...$payloads): void
    {
        $socket = $this->makeSocket($fd, $nsp);
        if (empty($socket)) {
            return;
        }
        $ack = null;

        // Check if ack is required
        $last = array_pop($payloads);
        if ($last instanceof Closure) {
            $ack = $last;
        } else {
            array_push($payloads, $last);
        }

        $handlers = $this->getEventHandlers($nsp, $event);
        foreach ($handlers as $handler) {
            $result = $handler($socket, ...$payloads);
            $ack && $ack([$result]);
        }
    }