hyperledger / indy-did-method

Indy DID Method Specification
https://hyperledger.github.io/indy-did-method/
Creative Commons Attribution 4.0 International
18 stars 14 forks source link

Service block from ATTRIB endpoint data #46

Closed domwoe closed 2 years ago

domwoe commented 2 years ago

I could be wrong, but I think the service block in section The “endpoint” ATTRIB is outdated.

The service block from the spec:

"diddocContent" : {
  "@context" : [ "https://identity.foundation/didcomm-messaging/service-endpoint/v1" ],
  "service": [
    {
      "id": "did:indy:<namespace>:<dest>#didcomm",
      "type": "didcomm-messaging",
      "serviceEndpoint": "<ENDPOINT>",
      "recipientKeys": [ "#verkey" ],
      "routingKeys": [ ]
    }
  ]
}

In contrast, currently, the sov/indy resolver would produce a service block like this:

  "service": [
    {
      "id": "did:indy:<namespace>:<dest>#did-communication",
      "type": "did-communication",
      "serviceEndpoint": "<ENDPOINT>",
      "recipientKeys": [ "#verkey" ],
      "routingKeys": [ ],
      "priority": 0
    }
  ]

which is however also not compliant with this Sovrin DID Method Spec...

paulbastian commented 2 years ago

whats the difference apart from the priority?

domwoe commented 2 years ago

the type

domwoe commented 2 years ago

Found the reference in the Aries RFC

Priority is actually mandatory. I'll do a PR to change the spec accordingly.

Btw, shouldn't I be able to self-assign myself?