hyperledger / indy-did-method

Indy DID Method Specification
https://hyperledger.github.io/indy-did-method/
Creative Commons Attribution 4.0 International
18 stars 14 forks source link

Add Indy Besu identifiers and entities #86

Closed Toktar closed 3 months ago

Toktar commented 5 months ago

This PR adds Hyperledger Indy Besu specific identifiers and entities to original Indy DID Method. During this work, we define Indy Besu identifiers like did:indy:besu:<network-identidier>:<ethereum-address-identifier>

TODO:

TelegramSam commented 5 months ago

Do we anticipate more than one besu-based ledger? On first pass, it references the besu ledger as a singular thing.

Toktar commented 5 months ago

Do we anticipate more than one besu-based ledger? On first pass, it references the besu ledger as a singular thing.

Do you mean instances of Indy-Besu networks or ledgers included in one instance? Compared to original Indy, there are not 3 ledgers within the system, but only one. And of course, any amount of network instances.

TelegramSam commented 4 months ago

I like this - I do think we need a document history added, indicating the date changes were made to add the besu style ledgers. This will help avoid confusion for those looking at the method again.

Toktar commented 4 months ago

@TelegramSam Thanks a lot for your review. Updated according to your comments. Could you please take a look at it with all the rigor and with fresh eyes?

TelegramSam commented 4 months ago

This is looking great. Thanks for all the work and incorporating feedback.