Follow up: Docs: "Fixed Config example in Docs" - added new database connection settings to examples

hyperledger / iroha

Iroha - A simple, enterprise-grade decentralized ledger

https://wiki.hyperledger.org/display/iroha

Apache License 2.0

433 stars 277 forks source link

Follow up: Docs: "Fixed Config example in Docs" - added new database connection settings to examples #1081

Open baziorek opened 3 years ago

baziorek commented 3 years ago

This is follow up to: https://github.com/hyperledger/iroha/pull/1037

In the previous PR example file https://github.com/hyperledger/iroha/blob/main/example/config.sample was updated. But also there are other two sample files with the same (deprecated) connection string: https://github.com/hyperledger/iroha/blob/main/example/config-win.sample https://github.com/hyperledger/iroha/blob/main/example/config.docker I think they should be also updated

LiraLemur commented 3 years ago

Thank you @baziorek !

Although it seems like there is a bigger problem here anyway: https://github.com/hyperledger/iroha/issues/1079 I think we can postpone this issue till after the 1079 is resolved

baziorek commented 3 years ago

I think we can postpone this issue till after the 1079 is resolved

Not problem.

BTW. I see it is subtask for me (inside #1079). Sometimes is possible that I don't see pings, so please let me know through Telegram if I don't reply in longer time.