search

hyperledger / iroha

Iroha - A simple, enterprise-grade decentralized ledger
https://wiki.hyperledger.org/display/iroha
Apache License 2.0
424 stars 276 forks source link

[suggestion] Move `NewParameter` into Executor #3901

Open mversic opened 10 months ago

mversic commented 10 months ago

We should consider removing NewParameter ISI and only allow defining new parameters in Executor. During Executor migration old parameters will be removed and new ones can be added. The reason is that having an ISI doesn't make sense for an operation that can only be executed by the blockchain admin

Arjentix commented 9 months ago

I think that would be right

0x009922 commented 2 months ago

What means "move NewParameter into Executor"?

As far as I understand, Executor just has access to all parameters, to the key-value storage with some data. And, Executor just "interprets" certain keys in a certain way which defines Executor's behaviour.

Is it needed for Executor to define "known" parameters in some way?

mversic commented 2 months ago

just look at how permission tokens are defined in Executor. We need to replicate that mechanism