search

hyperledger / iroha

Iroha - A simple, enterprise-grade decentralized ledger
https://wiki.hyperledger.org/display/iroha
Apache License 2.0
432 stars 276 forks source link

[refactor]: Improve decoding of `ChainId` #4197

Open Erigara opened 8 months ago

Erigara commented 8 months ago 
          This could be improved by using constructor `fn new(inner: impl Into<Box<str>>)`.

I will extract it into separate good first issue.

_Originally posted by @Erigara in https://github.com/hyperledger/iroha/pull/4185#discussion_r1450199917_

Idea is to remove redundant clone by directly convert from String to Box<str>.

mversic commented 8 months ago

remove custom Decode implementation for ChainId after this PR is merged

Erigara commented 8 months ago

@mversic oh it will be much better solution