hyperledger / iroha

Iroha - A simple, enterprise-grade decentralized ledger
https://wiki.hyperledger.org/display/iroha
Apache License 2.0
421 stars 275 forks source link

Allow multiple peers to submit genesis #4388

Closed mversic closed 2 days ago

mversic commented 3 months ago

read discussion in #4225

Erigara commented 1 month ago

When implementing this feature care should be taken to insure that every peer produce the same genesis block.

Currently while still having the same genesis transaction other parts of BlockPayload could differ. Most likely commit_topology and timestamp_ms in BlockHeader.

This differences could lead to iroha fail to agree on genesis block.

mversic commented 1 month ago

I was thinking that kagami genesis sign produces a genesis block? and that block which is produced only once can be submitted by any peer whatsoever

Erigara commented 1 month ago

I was thinking that kagami genesis sign produces a genesis block?

No, atm we put genesis transaction in the block builder. So it's not full block yet.

dima74 commented 2 days ago

Implemented in #4775 (#4696)