Fix `with_coverage` - Githubissues

mversic commented 6 months ago

After merging #4414 with_coverage is failing

AlexStroke commented 6 months ago

telegram-cloud-photo-size-2-5381943039976656869-y FYI This is 6th February 2024 report using the new grcov tool from Vasiliy

s8sato commented 5 months ago

As of 2cf50c0da I2::Dev::Tests / with_coverage is failing due to -p iroha_client --test mod (client/tests/integration/). It seems to happen with the following combination:

nightly-2024-04-18
RUSTFLAGS="-C instrument-coverage"
-p iroha_client --test mod
- not filtered out, because #[cfg(not(coverage))] is allowed by cargo-llvm-cov and does not work with grcov

I don't know the exact cause, but we can work around this. Just exclude the client integration tests in command without attributes

hyperledger / iroha

Fix `with_coverage` #4488