Snapshot seed serialization issue

hyperledger / iroha

Iroha - A simple, enterprise-grade decentralized ledger

https://wiki.hyperledger.org/display/iroha

Apache License 2.0

433 stars 277 forks source link

Snapshot seed serialization issue #4726

Closed mversic closed 1 month ago

mversic commented 2 months ago

I have noticed that in impl<'de> DeserializeSeed<'de> for WasmSeed<'_, World> next_key_seed is not called before next_value_seed as documentation states should be done. Is this ok?

For KuraSeed as well

Erigara commented 1 month ago

@mversic we call .next_key() which is the same as calling .next_key_seed(PhantomData) (link)