hyperledger / iroha

Iroha - A simple, enterprise-grade decentralized ledger
https://wiki.hyperledger.org/display/iroha
Apache License 2.0
434 stars 277 forks source link

Validate genesis instructions #4743

Closed mversic closed 3 months ago

mversic commented 3 months ago

A thing that I have noticed. We don't validate genesis instructions at all anymore because there is no initial executor. This is a bug, only the 1st instruction (which is upgrade) should not be validated, all others should

Originally posted by @mversic in https://github.com/hyperledger/iroha/issues/4739#issuecomment-2178400860

mversic commented 3 months ago

this can most easily be solved by enforcing genesis to have 2 transactions instead of 1 where 1st is Upgrade<Executor> and 2nd contains all other instructions

AlexStroke commented 3 months ago

[Uploading... image.png]image.png