Audit logs produced by iroha

hyperledger / iroha

Iroha - A simple, enterprise-grade decentralized ledger

https://wiki.hyperledger.org/display/iroha

Apache License 2.0

433 stars 277 forks source link

Audit logs produced by iroha #4842

Closed Erigara closed 1 week ago

Erigara commented 1 month ago

Atm iroha produce to much logs on level INFO which cause x5 degradation in performance compared to ERROR level.

What could be done:

decrease log level
remove logging from hot loops and print aggregated info
less verbose printing (i.e. do not print whole transaction with all instructions)

Erigara commented 1 month ago

So far there is no significant amount of logs produced at level INFO.

Afaik situation improved when we moved to axum in #4718 after which endpoint related logs were moved to DEBUG level from INFO.

Imo another round of performance testing should be made in order to check is issue resolved.

timofeevmd commented 1 month ago

For a comparative performance analysis, an image with the hash 50e81042 based on Debian was used.

The maximum performance with logging level set to INFO is 1998 RPS, and with logging level set to DEBUG is 1945 RPS. The throughput degradation was 2.64%.

No resource utilization leaks were detected.

Gatling report log_level_debug.zip log_level_error.zip

dmitrivenger commented 3 weeks ago

@Erigara can we close this task?

Erigara commented 1 week ago

@dmitrivenger yes, there were no issues which affected performance