hyperledger / iroha

Iroha - A simple, enterprise-grade decentralized ledger
https://wiki.hyperledger.org/display/iroha
Apache License 2.0
433 stars 277 forks source link

Allow `EventFilterBox::TriggerCompleted` as a trigger filter #4869

Open mversic opened 1 month ago

mversic commented 1 month ago
          I still not sure why we should treat trigger completion event separately. 

It was requested like that in #2885, but reasons are not specified.

Originally posted by @Erigara in https://github.com/hyperledger/iroha/pull/4866#pullrequestreview-2191212630

DCNick3 commented 1 month ago

I think the concern with allowing a trigger like that is that it can lead to infinite trigger loop if used improperly, possibly leading to DoS.

Erigara commented 1 month ago

Right now it not that hard to create such infinite loop as well.

You can create trigger which modifies it's own metadata and listen to events about metadata modifications of itself.

mversic commented 2 weeks ago

related #4429