search

hypertrace / hypertrace-service

Multiple hypertrace services combined together to form a single service.
Other
4 stars 15 forks source link

chore: Update submodule #102

Closed findingrish closed 3 years ago

findingrish commented 3 years ago

Update submodule and gradle version

findingrish commented 3 years ago

Build is failing due to following error 

* What went wrong:
org.gradle.api.internal.catalog.GeneratedClassCompilationException: Unable to compile generated sources:
  - File RootProjectAccessor.java, line: 39, method getAttributeService() is already defined in class org.gradle.accessors.dm.RootProjectAccessor
> Unable to compile generated sources:
    - File RootProjectAccessor.java, line: 39, method getAttributeService() is already defined in class org.gradle.accessors.dm.RootProjectAccessor

Probably need to change the root project name for other repos

aaron-steinfeld commented 3 years ago

Build is failing due to following error

* What went wrong:
org.gradle.api.internal.catalog.GeneratedClassCompilationException: Unable to compile generated sources:
  - File RootProjectAccessor.java, line: 39, method getAttributeService() is already defined in class org.gradle.accessors.dm.RootProjectAccessor
> Unable to compile generated sources:
    - File RootProjectAccessor.java, line: 39, method getAttributeService() is already defined in class org.gradle.accessors.dm.RootProjectAccessor

Probably need to change the root project name for other repos

yep, that's part of the work needed for typed project accessors - root and child can't have the same name. I'm guessing the submodule's upgrade forced the upgrade of this repo?

I believe you could shortcut it by renaming the included builds in the composite project, but we should do it everywhere eventually. e.g.

includeBuild("./some-path") {
  name = "some-path-root"
}
findingrish commented 3 years ago

I'm guessing the submodule's upgrade forced the upgrade of this repo?

yep