search

hypertrace / hypertrace-service

Multiple hypertrace services combined together to form a single service.
Other
4 stars 15 forks source link

Fixes startup exceptions happens which happens before dependent services is up #39

Closed kotharironak closed 3 years ago

kotharironak commented 3 years ago

Address the issue - https://github.com/hypertrace/query-service/issues/29

jcchavezs commented 3 years ago

I think keeping a style consistent is good. Lets please add a check in a next PR all with the fix for all files.

On Thu, 15 Oct 2020, 16:57 kotharironak, notifications@github.com wrote:

@kotharironak commented on this pull request.

In hypertrace-service/src/main/java/org/hypertrace/service/HypertraceUIServerTimerTask.java https://github.com/hypertrace/hypertrace-service/pull/39#discussion_r505610950 :

  • public HypertraceUIServerTimerTask(Config appConfig, HypertraceUIServer uiServer, String defaultTenant) {
  • maxRetries = appConfig.hasPath(RETRIES_CONFIG) ? appConfig.getInt(RETRIES_CONFIG) : DEFAULT_RETRIES;
  • timeout = appConfig.hasPath(TIMEOUT_CONFIG) ? appConfig.getInt(TIMEOUT_CONFIG) : DEFAULT_TIMEOUT;
  • public HypertraceUIServerTimerTask(Config appConfig, HypertraceUIServer uiServer,
  • String defaultTenant) {

Formatting changed, applied google style

In hypertrace-service/src/main/java/org/hypertrace/service/HypertraceUIServerTimerTask.java https://github.com/hypertrace/hypertrace-service/pull/39#discussion_r505611139 :

 interval = appConfig.hasPath(INTERVAL) ? appConfig.getInt(INTERVAL) : DEFAULT_INTERVAL;
  • startPeriod = appConfig.hasPath(START_PERIOD) ? appConfig.getInt(START_PERIOD) : DEFAULT_START_PERIOD;
  • startPeriod =

Formatting changed, applied google style

In hypertrace-service/src/main/java/org/hypertrace/service/HypertraceUIServerTimerTask.java https://github.com/hypertrace/hypertrace-service/pull/39#discussion_r505611243 :

pinotSeverHost = appConfig.hasPath(PINOT_SERVER_HOST) ?

  • appConfig.getString(PINOT_SERVER_HOST) : DEFAULT_PINOT_SERVER_HOST;
  • appConfig.getString(PINOT_SERVER_HOST) : DEFAULT_PINOT_SERVER_HOST;

Formatting changed, applied google style

In hypertrace-service/src/main/java/org/hypertrace/service/HypertraceUIServerTimerTask.java https://github.com/hypertrace/hypertrace-service/pull/39#discussion_r505611331 :

client = GatewayServiceGrpc.newBlockingStub(ManagedChannelBuilder.forAddress(

  • "localhost", appConfig.getInt("service.port")).usePlaintext().build())
  • .withCallCredentials(RequestContextClientCallCredsProviderFactory
  • .getClientCallCredsProvider().get());
  • "localhost", appConfig.getInt("service.port")).usePlaintext().build())

Formatting changed, applied google style

In hypertrace-service/src/main/java/org/hypertrace/service/HypertraceUIServerTimerTask.java https://github.com/hypertrace/hypertrace-service/pull/39#discussion_r505611488 :

     cancel();

LOGGER.info(String.format("Stack is up after [%s] attempts, and duration [%s] in millis.",

  • numRetries, Instant.now().toEpochMilli() - startTime));
  • numRetries, Instant.now().toEpochMilli() - startTime));

Formatting changed, applied google style

In hypertrace-service/src/main/java/org/hypertrace/service/HypertraceUIServerTimerTask.java https://github.com/hypertrace/hypertrace-service/pull/39#discussion_r505611607 :

 } finally {

numRetries++; } }

private boolean executeHealthCheck() { SpansResponse response = GrpcClientRequestContextUtil.executeInTenantContext(defaultTenant,

  • () -> client.withDeadline(Deadline.after(timeout, TimeUnit.SECONDS))
  • .getSpans(buildSpanRequest()));
  • () -> client.withDeadline(Deadline.after(timeout, TimeUnit.SECONDS))

Formatting changed, applied google style

In hypertrace-service/src/main/java/org/hypertrace/service/HypertraceUIServerTimerTask.java https://github.com/hypertrace/hypertrace-service/pull/39#discussion_r505611681 :

 return response.getSpansCount() >= 0;

}

private SpansRequest buildSpanRequest() { return SpansRequest.newBuilder()

  • .setStartTimeMillis(System.currentTimeMillis() - TimeUnit.SECONDS.toMillis(10))
  • .setEndTimeMillis(System.currentTimeMillis())
  • .addSelection(QueryExpressionUtil.getColumnExpression("EVENT.id"))
  • .setLimit(1)
  • .build();
  • .setStartTimeMillis(System.currentTimeMillis() - TimeUnit.SECONDS.toMillis(10))

Formatting changed, applied google style

In hypertrace-service/src/main/java/org/hypertrace/service/HypertraceUIServerTimerTask.java https://github.com/hypertrace/hypertrace-service/pull/39#discussion_r505611823 :

@@ -157,7 +187,8 @@ private boolean executePinotHealthCheck() throws Exception { private boolean executeBrokerRegistrationCheck() throws Exception { HttpURLConnection con = null; try {

Formatting changed, applied google style

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hypertrace/hypertrace-service/pull/39#pullrequestreview-509473154, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXOYAVFYA4XQTPSJKRYMYDSK4EWZANCNFSM4SSDE4LQ .

kotharironak commented 3 years ago

It helps in fixing the issue - https://github.com/hypertrace/hypertrace-service/issues/40