hypertrace / hypertrace-service

Multiple hypertrace services combined together to form a single service.
Other
4 stars 15 forks source link

enables support for running docker-compose setup with postgres #49

Closed kotharironak closed 3 years ago

kotharironak commented 3 years ago

Description

Enables support for running docker-compose setup with postgres ref : https://github.com/hypertrace/hypertrace/issues/124

Testing

Tested locally as below

Screenshot 2020-11-27 at 9 23 55 AM

Checklist:

Documentation

will add documentation as part of final PR - https://github.com/hypertrace/hypertrace/pull/130

jcchavezs commented 3 years ago

Question: what will happen if you pass both Mongo host and Postgres host?

On Fri, 27 Nov 2020, 09:25 Jayesh Bapu Ahire, notifications@github.com wrote:

@JBAhire approved this pull request.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/hypertrace/hypertrace-service/pull/49#pullrequestreview-539784213, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXOYATHXEJGNFNZURRVSWLSR5PAPANCNFSM4UENGETA .

kotharironak commented 3 years ago

Question: what will happen if you pass both Mongo host and Postgres host? On Fri, 27 Nov 2020, 09:25 Jayesh Bapu Ahire, @.**> wrote: @JBAhire* approved this pull request. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#49 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXOYATHXEJGNFNZURRVSWLSR5PAPANCNFSM4UENGETA .

That won't be an issue. The variable dataStoreType defined the underlying store.