ci: migrating to GitHub actions - Githubissues

hypertrace / hypertrace-service

Multiple hypertrace services combined together to form a single service.

Other

4 stars 15 forks source link

ci: migrating to GitHub actions #57

Closed JBAhire closed 3 years ago

JBAhire commented 3 years ago

Description

Migrating to GitHub actions from CircleCI as per https://github.com/hypertrace/hypertrace/issues/144

Testing

changes are updates as per discussions and workflow here: https://github.com/hypertrace/query-service/pull/47

Checklist:

[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] Any dependent changes have been merged and published in downstream modules

Documentation

https://docs.github.com/en/free-pro-team@latest/actions

github-actions[bot] commented 3 years ago

Unit Test Results

0 files 0 suites 0s :stopwatch: 0 tests 0 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit f7596f22.

github-actions[bot] commented 3 years ago

Unit Test Results

0 files 0 suites 0s :stopwatch: 0 tests 0 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 7a226c19.

github-actions[bot] commented 3 years ago

Unit Test Results

0 files 0 suites 0s :stopwatch: 0 tests 0 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit c9de39b9.

github-actions[bot] commented 3 years ago

Unit Test Results

0 files 0 suites 0s :stopwatch: 0 tests 0 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 802a59a4.

github-actions[bot] commented 3 years ago

Unit Test Results

0 files 0 suites 0s :stopwatch: 0 tests 0 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit e06dd147.

github-actions[bot] commented 3 years ago

Unit Test Results

0 files 0 suites 0s :stopwatch: 0 tests 0 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit e06dd147.

github-actions[bot] commented 3 years ago

Unit Test Results

0 files 0 suites 0s :stopwatch: 0 tests 0 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 11e673c3.

JBAhire commented 3 years ago

removed codecov, upload-artifact and publish action here as this repo doesn't generate any test reports: https://app.circleci.com/pipelines/github/hypertrace/hypertrace-service/257/workflows/f9676140-16d4-406b-8d14-afb568f57951/jobs/773/parallel-runs/0/steps/0-112

JBAhire commented 3 years ago

waiting for https://github.com/hypertrace/hypertrace-gradle-docker-plugins/pull/22 to get merged as there's tag issue with e2e test here.

In case of PR, value of env variable GITHUB_REF is in the format of refs/pull/57/merge and docker image tag is returned as refspull57merge which results in e2e failure as we were using test tag.

I have made change in docker-compose file here so it will use GITHUB_HEAD_REF as tag for hypertrace service image.

JBAhire commented 3 years ago

waiting for hypertrace/hypertrace-gradle-docker-plugins#22 to get merged as there's tag issue with e2e test here.

In case of PR, value of env variable GITHUB_REF is in the format of refs/pull/57/merge and docker image tag is returned as refspull57merge which results in e2e failure as we were using test tag.

I have made change in docker-compose file here so it will use GITHUB_HEAD_REF as tag for hypertrace service image.

This is no longer an dependency. We can move ahead without this change: https://github.com/hypertrace/hypertrace-service/pull/57#discussion_r552592957