hypertrace / javaagent

Hypertrace OpenTelemetry Java agent with payload/body and headers data capture.
Apache License 2.0
30 stars 15 forks source link

Remove bugy, disabled instrumentation #314

Closed pavolloffay closed 3 years ago

pavolloffay commented 3 years ago

Removes "all" alternative instrumentation from apache async client. It's disabled by default and does not pass all client tests.

pavolloffay commented 3 years ago

@ryandens

  "command": "bad-command",
  "org": "hypertrace",
  "metadata": {
    "error-message": "`snyk` requires an authenticated account. Please run `snyk auth` and try again.",
    "error": "MissingApiTokenError: `snyk` requires an authenticated account. Please run `snyk auth` and try again.\n    at Object.apiTokenExists (/snapshot/snyk/dist/lib/api-token.js:23:15)\n    at Object.validateCredentials (/snapshot/snyk/dist/cli/commands/test/validate-credentials.js:7:21)\n    at test (/snapshot/snyk/dist/cli/commands/test/index.js:33:28)\n    at Object.method (/snapshot/snyk/dist/lib/hotload.js:14:20)\n    at runCommand (/snapshot/snyk/dist/cli/index.js:44:38)\n    at main (/snapshot/snyk/dist/cli/index.js:253:21)\n    at Object.<anonymous> (/snapshot/snyk/dist/cli/index.js:270:13)\n    at Module._compile (pkg/prelude/bootstrap.js:1503:22)\n    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)\n    at Module.load (internal/modules/cjs/loader.js:863:32)\n    at Function.Module._load (internal/modules/cjs/loader.js:708:14)\n    at Function.runMain (pkg/prelude/bootstrap.js:1558:12)\n    at internal/main/run_main_module.js:17:47",
    "error-code": 401,
    "command": "test"
  },

it seems snyk is failing on auth.

ryandens commented 3 years ago

Thanks, @pavolloffay! I'm taking a look now